Bug 113664 - NetworkProcess crashes in WebCoreResourceHandleAsOperationQueueDelegate callbacks
Summary: NetworkProcess crashes in WebCoreResourceHandleAsOperationQueueDelegate callb...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Macintosh All
: P2 Normal
Assignee: Brady Eidson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2013-03-31 13:01 PDT by Brady Eidson
Modified: 2013-03-31 13:12 PDT (History)
2 users (show)

See Also:


Attachments
Patch v1 (3.44 KB, patch)
2013-03-31 13:04 PDT, Brady Eidson
mitz: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2013-03-31 13:01:03 PDT
NetworkProcess crashes in WebCoreResourceHandleAsOperationQueueDelegate callbacks

In the "two part" callbacks that do a dispatch_async followed by a dispatch_semaphore_wait the delegate might have been released and destroyed by the time the semaphore returns.

This is bad, and can be fixed with a RetainPtr<> protector.

In radar as <rdar://problem/13541868>
Comment 1 Brady Eidson 2013-03-31 13:04:07 PDT
Created attachment 195904 [details]
Patch v1
Comment 2 Brady Eidson 2013-03-31 13:12:21 PDT
http://trac.webkit.org/changeset/147287