Bug 113652 - [Chromium] Yarr should build using a separate GYP file from JavaScriptCore
Summary: [Chromium] Yarr should build using a separate GYP file from JavaScriptCore
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-30 21:04 PDT by Adam Barth
Modified: 2013-03-31 20:05 PDT (History)
7 users (show)

See Also:

Attachments
Patch (12.45 KB, patch)
2013-03-30 21:05 PDT, Adam Barth 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2013-03-30 21:04:04 PDT 
[Chromium] Yarr should build using a separate GYP file from JavaScriptCore
Comment 1 Adam Barth 2013-03-30 21:05:20 PDT 
Created attachment 195886 [details]
Patch
Comment 2 Nico Weber 2013-03-31 19:51:03 PDT 
Duplicating the yarr files in two places makes sense to me as they don't change often, and the GTK port doesn't need the separate target from what I can tell. +mrobinson for his information.
Comment 3 Martin Robinson 2013-03-31 19:52:33 PDT 
Comment on attachment 195886 [details]
Patch

This makes a lot of sense. :)
Comment 4 WebKit Review Bot 2013-03-31 20:05:18 PDT 
Comment on attachment 195886 [details]
Patch

Clearing flags on attachment: 195886

Committed r147294: <http://trac.webkit.org/changeset/147294>
Comment 5 WebKit Review Bot 2013-03-31 20:05:23 PDT 
All reviewed patches have been landed.  Closing bug.