Bug 113645 – [GTK] Configure should verify ICU is installed on mingw

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Eric Gregory]

I was able to pass ./configure on my system without having ICU installed.  This lead to a few minutes of head scratching when make failed.

AFAIK you can use pkg-config with ICU, just like many of WebKitGTK's other dependencies.

[Zan Dobersek]

Currently ICU is checked for using the icu-config, though there's a TODO mentioning switching to using pkg-config for the task.
http://trac.webkit.org/browser/trunk/Source/autotools/FindDependencies.m4#L109

Can you give a bit more description of what the failure was? I guess it should be fixed one way or the other even if not using pkg-config.

[Martin Robinson]

(In reply to comment #1)
> Currently ICU is checked for using the icu-config, though there's a TODO mentioning switching to using pkg-config for the task.
> http://trac.webkit.org/browser/trunk/Source/autotools/FindDependencies.m4#L109
> 
> Can you give a bit more description of what the failure was? I guess it should be fixed one way or the other even if not using pkg-config.

The debian package for ICU and indeed earlier versions of ICU itself did not install .pc files. The correct thing to do is to check pkg-config for ICU and then fall back to icu-config. I'm not sure what's up with the original bug report. I'm not sure why invoking icu-config doesn't fail when the development packages aren't installed.

[Eric Gregory]

I'm building on mingw.  The ./configure script didn't warn me at all about ICU.

[Martin Robinson]

(In reply to comment #3)
> I'm building on mingw.  The ./configure script didn't warn me at all about ICU.

It seems that for mingw and OS X the headers and link arguments are just hard-coded. It should instead call AC_CHECK_HEADERS.

[Eric Gregory]

Thanks for looking into this!

There's a few other hurdles building on mingw, but it looks like many of them are already ticketed.

[Martin Robinson]

Created attachment 195915 [details]
Patch

[Martin Robinson]

Eric, do you mind verifying that the patch I posted for this issue works? Thanks!

[WebKit Commit Bot]

Comment on attachment 195915 [details]
Patch

Clearing flags on attachment: 195915

Committed r147951: <http://trac.webkit.org/changeset/147951>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.