Bug 113645 - [GTK] Configure should verify ICU is installed on mingw
Summary: [GTK] Configure should verify ICU is installed on mingw
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Martin Robinson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-30 16:34 PDT by Eric Gregory
Modified: 2013-04-08 14:06 PDT (History)
4 users (show)

See Also:


Attachments
Patch (1.28 KB, patch)
2013-03-31 19:18 PDT, Martin Robinson
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Gregory 2013-03-30 16:34:41 PDT
I was able to pass ./configure on my system without having ICU installed.  This lead to a few minutes of head scratching when make failed.

AFAIK you can use pkg-config with ICU, just like many of WebKitGTK's other dependencies.
Comment 1 Zan Dobersek 2013-03-30 22:02:49 PDT
Currently ICU is checked for using the icu-config, though there's a TODO mentioning switching to using pkg-config for the task.
http://trac.webkit.org/browser/trunk/Source/autotools/FindDependencies.m4#L109

Can you give a bit more description of what the failure was? I guess it should be fixed one way or the other even if not using pkg-config.
Comment 2 Martin Robinson 2013-03-30 22:55:10 PDT
(In reply to comment #1)
> Currently ICU is checked for using the icu-config, though there's a TODO mentioning switching to using pkg-config for the task.
> http://trac.webkit.org/browser/trunk/Source/autotools/FindDependencies.m4#L109
> 
> Can you give a bit more description of what the failure was? I guess it should be fixed one way or the other even if not using pkg-config.

The debian package for ICU and indeed earlier versions of ICU itself did not install .pc files. The correct thing to do is to check pkg-config for ICU and then fall back to icu-config. I'm not sure what's up with the original bug report. I'm not sure why invoking icu-config doesn't fail when the development packages aren't installed.
Comment 3 Eric Gregory 2013-03-31 12:07:21 PDT
I'm building on mingw.  The ./configure script didn't warn me at all about ICU.
Comment 4 Martin Robinson 2013-03-31 12:22:42 PDT
(In reply to comment #3)
> I'm building on mingw.  The ./configure script didn't warn me at all about ICU.

It seems that for mingw and OS X the headers and link arguments are just hard-coded. It should instead call AC_CHECK_HEADERS.
Comment 5 Eric Gregory 2013-03-31 13:03:09 PDT
Thanks for looking into this!

There's a few other hurdles building on mingw, but it looks like many of them are already ticketed.
Comment 6 Martin Robinson 2013-03-31 19:18:52 PDT
Created attachment 195915 [details]
Patch
Comment 7 Martin Robinson 2013-03-31 19:19:09 PDT
Eric, do you mind verifying that the patch I posted for this issue works? Thanks!
Comment 8 WebKit Commit Bot 2013-04-08 14:06:16 PDT
Comment on attachment 195915 [details]
Patch

Clearing flags on attachment: 195915

Committed r147951: <http://trac.webkit.org/changeset/147951>
Comment 9 WebKit Commit Bot 2013-04-08 14:06:20 PDT
All reviewed patches have been landed.  Closing bug.