Bug 11362 - Native popup with size="1" wraps options
Summary: Native popup with size="1" wraps options
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: 420+
Hardware: Macintosh OS X 10.4
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-10-19 16:13 PDT by mitz
Modified: 2007-04-11 22:04 PDT (History)
1 user (show)

See Also:


Attachments
Test case (390 bytes, text/html)
2006-10-19 16:14 PDT, mitz
no flags Details
Fix html4.css (37.28 KB, patch)
2007-04-06 01:08 PDT, mitz
hyatt: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description mitz 2006-10-19 16:13:46 PDT
Specifying size="1" for a non-themed popup makes long options wrap and make the popup taller when they're selected. See attached test case.
Comment 1 mitz 2006-10-19 16:14:23 PDT
Created attachment 11158 [details]
Test case
Comment 2 mitz 2006-10-19 16:15:59 PDT
I noticed this bug in the Web Inspector's tree popup.
Comment 3 mitz 2007-03-31 08:25:12 PDT
html4.css has the following:

keygen, select {
    ...
    white-space: pre;
}

select[size],
select[multiple],
select[size][multiple] {
    ...
    white-space: initial;
}

select[size="0"],
select[size="1"] {
    ... /* no white-space declaration */
}

white-space should probably be set to pre again in the more specific case of size="0" or size="1". Doing this in the stylesheet without !important would still allow the author to have popups wrap. I'm not sure you want to allow that.
Comment 4 mitz 2007-04-06 01:08:47 PDT
Created attachment 13977 [details]
Fix html4.css

Also added missing border-radius to the 'select' rule and cleaned up a little.
Comment 5 Dave Hyatt 2007-04-06 01:11:40 PDT
Comment on attachment 13977 [details]
Fix html4.css

r=me
Comment 6 Mark Rowe (bdash) 2007-04-11 22:04:07 PDT
Landed in r20857.