Bug 113617 - Move Region into its own header
Summary: Move Region into its own header
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Hahnenberg
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-29 16:01 PDT by Mark Hahnenberg
Modified: 2013-03-30 12:00 PDT (History)
2 users (show)

See Also:

Attachments
Patch (16.95 KB, patch)
2013-03-29 16:07 PDT, Mark Hahnenberg 		no flags Details | Formatted Diff | Diff
Patch (17.12 KB, patch)
2013-03-29 16:35 PDT, Mark Hahnenberg 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Hahnenberg 2013-03-29 16:01:39 PDT 
BlockAllocator.h is getting a little overloaded. We should move the Region class into its own header, since it's pretty independent from the BlockAllocator.
Comment 1 Mark Hahnenberg 2013-03-29 16:07:40 PDT 
Created attachment 195813 [details]
Patch
Comment 2 Early Warning System Bot 2013-03-29 16:19:00 PDT 
Comment on attachment 195813 [details]
Patch

Attachment 195813 [details] did not pass qt-ews (qt):
Output: http://webkit-commit-queue.appspot.com/results/17311740
Comment 3 Mark Hahnenberg 2013-03-29 16:35:03 PDT 
Created attachment 195818 [details]
Patch
Comment 4 WebKit Review Bot 2013-03-29 16:38:14 PDT 
Attachment 195818 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source/JavaScriptCore/GNUmakefile.list.am', u'Source/JavaScriptCore/JavaScriptCore.gypi', u'Source/JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj', u'Source/JavaScriptCore/JavaScriptCore.vcxproj/JavaScriptCore.vcxproj', u'Source/JavaScriptCore/JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters', u'Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj', u'Source/JavaScriptCore/heap/BlockAllocator.h', u'Source/JavaScriptCore/heap/Region.h']" exit_code: 1
Source/JavaScriptCore/heap/Region.h:26:  #ifndef header guard has wrong style, please use: Region_h  [build/header_guard] [5]
Total errors found: 1 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Mark Hahnenberg 2013-03-29 16:39:25 PDT 
(In reply to comment #4)
> Attachment 195818 [details] did not pass style-queue:
> 
> Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source/JavaScriptCore/GNUmakefile.list.am', u'Source/JavaScriptCore/JavaScriptCore.gypi', u'Source/JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj', u'Source/JavaScriptCore/JavaScriptCore.vcxproj/JavaScriptCore.vcxproj', u'Source/JavaScriptCore/JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters', u'Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj', u'Source/JavaScriptCore/heap/BlockAllocator.h', u'Source/JavaScriptCore/heap/Region.h']" exit_code: 1
> Source/JavaScriptCore/heap/Region.h:26:  #ifndef header guard has wrong style, please use: Region_h  [build/header_guard] [5]
> Total errors found: 1 in 9 files
> 
> 
> If any of these errors are false positives, please file a bug against check-webkit-style.

I had to do this because Region_h is used by another header in WebCore, and whichever one gets included first in a translation unit wins, causing build errors.
Comment 6 Geoffrey Garen 2013-03-29 16:51:08 PDT 
Comment on attachment 195818 [details]
Patch

r=me, please change to "Region_h", unless there's some conflict with that.
Comment 7 Mark Hahnenberg 2013-03-29 16:54:47 PDT 
(In reply to comment #6)
> (From update of attachment 195818 [details])
> r=me, please change to "Region_h", unless there's some conflict with that.

Yeah, there's a conflict with a header in WebCore.
Comment 8 WebKit Review Bot 2013-03-30 12:00:09 PDT 
Comment on attachment 195818 [details]
Patch

Clearing flags on attachment: 195818

Committed r147282: <http://trac.webkit.org/changeset/147282>
Comment 9 WebKit Review Bot 2013-03-30 12:00:12 PDT 
All reviewed patches have been landed.  Closing bug.