BlockAllocator.h is getting a little overloaded. We should move the Region class into its own header, since it's pretty independent from the BlockAllocator.
Created attachment 195813 [details] Patch
Comment on attachment 195813 [details] Patch Attachment 195813 [details] did not pass qt-ews (qt): Output: http://webkit-commit-queue.appspot.com/results/17311740
Created attachment 195818 [details] Patch
Attachment 195818 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source/JavaScriptCore/GNUmakefile.list.am', u'Source/JavaScriptCore/JavaScriptCore.gypi', u'Source/JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj', u'Source/JavaScriptCore/JavaScriptCore.vcxproj/JavaScriptCore.vcxproj', u'Source/JavaScriptCore/JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters', u'Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj', u'Source/JavaScriptCore/heap/BlockAllocator.h', u'Source/JavaScriptCore/heap/Region.h']" exit_code: 1 Source/JavaScriptCore/heap/Region.h:26: #ifndef header guard has wrong style, please use: Region_h [build/header_guard] [5] Total errors found: 1 in 9 files If any of these errors are false positives, please file a bug against check-webkit-style.
(In reply to comment #4) > Attachment 195818 [details] did not pass style-queue: > > Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source/JavaScriptCore/GNUmakefile.list.am', u'Source/JavaScriptCore/JavaScriptCore.gypi', u'Source/JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj', u'Source/JavaScriptCore/JavaScriptCore.vcxproj/JavaScriptCore.vcxproj', u'Source/JavaScriptCore/JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters', u'Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj', u'Source/JavaScriptCore/heap/BlockAllocator.h', u'Source/JavaScriptCore/heap/Region.h']" exit_code: 1 > Source/JavaScriptCore/heap/Region.h:26: #ifndef header guard has wrong style, please use: Region_h [build/header_guard] [5] > Total errors found: 1 in 9 files > > > If any of these errors are false positives, please file a bug against check-webkit-style. I had to do this because Region_h is used by another header in WebCore, and whichever one gets included first in a translation unit wins, causing build errors.
Comment on attachment 195818 [details] Patch r=me, please change to "Region_h", unless there's some conflict with that.
(In reply to comment #6) > (From update of attachment 195818 [details]) > r=me, please change to "Region_h", unless there's some conflict with that. Yeah, there's a conflict with a header in WebCore.
Comment on attachment 195818 [details] Patch Clearing flags on attachment: 195818 Committed r147282: <http://trac.webkit.org/changeset/147282>
All reviewed patches have been landed. Closing bug.