Bug 113610 – intrinsic size keywords don't work for heights

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Ojan Vafai]

http://dev.w3.org/csswg/css-sizing/

Right now we don't even parse them.

[Christian Biesinger]

FYI, the blink version of this code was:
https://codereview.chromium.org/13674002
https://code.google.com/p/chromium/issues/detail?id=226251

Note the followup in https://codereview.chromium.org/15112004/

[Sergio Villar Senin]

Created attachment 254721 [details]
Patch

[Sergio Villar Senin]

Pinging reviewers...

[Darin Adler]

Comment on attachment 254721 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=254721&action=review

Not at all fond of using the -1 magic value here.

> Source/WebCore/css/CSSParser.cpp:1817
> +bool CSSParser::isValidSize(ValueWithCalculation& valueWithCalculation)

If this has no side effects, maybe the argument type should be const& instead of just &.

> Source/WebCore/rendering/RenderBox.cpp:2819
> +    // FIXME: the css-sizing spec is considering changing what min-content/max-content should resolve to.

Should be sentence style. Also should be called CSS sizing, not css-sizing.

> Source/WebCore/rendering/RenderTable.cpp:374
> +    } else if (styleLogicalHeight.isPercentOrCalculated()) {
>          computedLogicalHeight = computePercentageLogicalHeight(styleLogicalHeight);
> +    } else if (styleLogicalHeight.isIntrinsic())

WebKit code says no braces for this kind of thing.

[Sergio Villar Senin]

Committed r185908: <http://trac.webkit.org/changeset/185908>

[Basile Clement]

Removed LayoutTests/fast/css-intrinsic-dimensions/height-property-value.html.orig in http://trac.webkit.org/changeset/187549