Bug 113600 – [CSS Exclusions] shape-outside on floats fails to respect shape-margin's vertical extent

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Hans Muller]

Lines of text that fall below a shape-outside don't conform to the shape-margin boundary.  See that attached test case and screenshot.

[Hans Muller]

Created attachment 195783 [details]
Test case.

[Hans Muller]

Created attachment 195785 [details]
Test case screenshot.

[Hans Muller]

Created attachment 195786 [details]
Test case.

Corrected a typo in the test cases's descriptive text.

[Hans Muller]

Created attachment 195835 [details]
Patch

[Dirk Schulze]

Comment on attachment 195835 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=195835&action=review

LGTM. Just some snippets.

> Source/WebCore/ChangeLog:9
> +        ExclusionShapeOutsideInfo classes should depend on the ExclusionShape's margin boundary.  Added

"boundary. A" unnecessary whitespace.

> Source/WebCore/rendering/ExclusionShapeInsideInfo.h:101
> +    virtual FloatRect computedShapeLogicalBoundingBox() const { return computedShape()->shapePaddingLogicalBoundingBox(); }

Add OVERRIDE makro at the end.

> Source/WebCore/rendering/ExclusionShapeOutsideInfo.h:55
> +    virtual FloatRect computedShapeLogicalBoundingBox() const { return computedShape()->shapeMarginLogicalBoundingBox(); }

Ditto.

[Hans Muller]

Created attachment 195999 [details]
Patch

Made the changes Dirk suggested.

[WebKit Review Bot]

Comment on attachment 195999 [details]
Patch

Clearing flags on attachment: 195999

Committed r147384: <http://trac.webkit.org/changeset/147384>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.