Bug 113600 - [CSS Exclusions] shape-outside on floats fails to respect shape-margin's vertical extent
Summary: [CSS Exclusions] shape-outside on floats fails to respect shape-margin's vert...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Hans Muller
URL:
Keywords:
Depends on: 113769
Blocks:
  Show dependency tree / graph
 
Reported: 2013-03-29 13:10 PDT by Hans Muller
Modified: 2013-04-02 04:53 PDT (History)
6 users (show)

See Also:

Attachments
Test case. (2.60 KB, text/html)
2013-03-29 13:11 PDT, Hans Muller 		no flags Details
Test case screenshot. (30.98 KB, image/png)
2013-03-29 13:14 PDT, Hans Muller 		no flags Details
Test case. (2.61 KB, text/html)
2013-03-29 13:15 PDT, Hans Muller 		no flags Details
Patch (21.36 KB, patch)
2013-03-29 18:38 PDT, Hans Muller 		krit: review+
krit: commit-queue-
Details | Formatted Diff | Diff
Patch (21.36 KB, patch)
2013-04-01 12:06 PDT, Hans Muller 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Hans Muller 2013-03-29 13:10:56 PDT 
Lines of text that fall below a shape-outside don't conform to the shape-margin boundary.  See that attached test case and screenshot.
Comment 1 Hans Muller 2013-03-29 13:11:24 PDT 
Created attachment 195783 [details]
Test case.
Comment 2 Hans Muller 2013-03-29 13:14:42 PDT 
Created attachment 195785 [details]
Test case screenshot.
Comment 3 Hans Muller 2013-03-29 13:15:31 PDT 
Created attachment 195786 [details]
Test case.

Corrected a typo in the test cases's descriptive text.
Comment 4 Hans Muller 2013-03-29 18:38:00 PDT 
Created attachment 195835 [details]
Patch
Comment 5 Dirk Schulze 2013-04-01 11:35:30 PDT 
Comment on attachment 195835 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=195835&action=review

LGTM. Just some snippets.

> Source/WebCore/ChangeLog:9
> +        ExclusionShapeOutsideInfo classes should depend on the ExclusionShape's margin boundary.  Added

"boundary. A" unnecessary whitespace.

> Source/WebCore/rendering/ExclusionShapeInsideInfo.h:101
> +    virtual FloatRect computedShapeLogicalBoundingBox() const { return computedShape()->shapePaddingLogicalBoundingBox(); }

Add OVERRIDE makro at the end.

> Source/WebCore/rendering/ExclusionShapeOutsideInfo.h:55
> +    virtual FloatRect computedShapeLogicalBoundingBox() const { return computedShape()->shapeMarginLogicalBoundingBox(); }

Ditto.
Comment 6 Hans Muller 2013-04-01 12:06:42 PDT 
Created attachment 195999 [details]
Patch

Made the changes Dirk suggested.
Comment 7 WebKit Review Bot 2013-04-01 22:38:24 PDT 
Comment on attachment 195999 [details]
Patch

Clearing flags on attachment: 195999

Committed r147384: <http://trac.webkit.org/changeset/147384>
Comment 8 WebKit Review Bot 2013-04-01 22:38:27 PDT 
All reviewed patches have been landed.  Closing bug.