RESOLVED FIXED 113579
Web Inspector: Flame Chart. Remove hopping ancorElement and use anchorBox instead. 
https://bugs.webkit.org/show_bug.cgi?id=113579
Summary Web Inspector: Flame Chart. Remove hopping ancorElement and use anchorBox ins...
Ilya Tikhonovsky
Reported 2013-03-29 07:02:45 PDT
Initially I made a fake anchor element and moved it according to the highlighted element position. It is a hack and after http://trac.webkit.org/changeset/147209 I'm able to remove it.
Attachments
Patch (4.17 KB, patch)
2013-03-29 07:04 PDT, Ilya Tikhonovsky 		no flags
DetailsFormatted DiffDiff
Patch (4.07 KB, patch)
2013-03-29 08:20 PDT, Ilya Tikhonovsky 		no flags
DetailsFormatted DiffDiff
Patch (5.70 KB, patch)
2013-03-29 09:05 PDT, Ilya Tikhonovsky 		pfeldman: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Ilya Tikhonovsky
Comment 1 2013-03-29 07:04:44 PDT
Created attachment 195743 [details] Patch
Andrey Lushnikov
Comment 2 2013-03-29 08:04:11 PDT
Comment on attachment 195743 [details] Patch What kind of behavior are you trying to archive? Changing popover's anchor location after returning it in |getPopoverAnchor| (by the means of |onMouseMove| method) seems to be hackish and might result in a popover located in a wrong place. Is it intentional? Why not just to create an anchorBox per every |getPopoverAnchor| call?
Andrey Lushnikov
Comment 3 2013-03-29 08:07:45 PDT
Comment on attachment 195743 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=195743&action=review > Source/WebCore/inspector/front-end/FlameChart.js:459 > + var canvasPaddingLeft = e.pageX - e.offsetX; > + var canvasPaddingTop = e.pageY - e.offsetY; Is it really padding or offset?
Ilya Tikhonovsky
Comment 4 2013-03-29 08:20:19 PDT
Created attachment 195751 [details] Patch
Ilya Tikhonovsky
Comment 5 2013-03-29 09:05:01 PDT
Created attachment 195754 [details] Patch
Ilya Tikhonovsky
Comment 6 2013-03-29 09:05:37 PDT
(In reply to comment #2) > (From update of attachment 195743 [details]) > What kind of behavior are you trying to archive? Changing popover's anchor location after returning it in |getPopoverAnchor| (by the means of |onMouseMove| method) seems to be hackish and might result in a popover located in a wrong place. Is it intentional? Why not just to create an anchorBox per every |getPopoverAnchor| call? done.
Ilya Tikhonovsky
Comment 7 2013-03-29 09:45:53 PDT
Committed r147224: <http://trac.webkit.org/changeset/147224>
Note You need to log in before you can comment on or make changes to this bug.