Bug 113579 - Web Inspector: Flame Chart. Remove hopping ancorElement and use anchorBox instead.
Summary: Web Inspector: Flame Chart. Remove hopping ancorElement and use anchorBox ins...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Ilya Tikhonovsky
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-29 07:02 PDT by Ilya Tikhonovsky
Modified: 2013-03-29 09:45 PDT (History)
8 users (show)

See Also:


Attachments
Patch (4.17 KB, patch)
2013-03-29 07:04 PDT, Ilya Tikhonovsky
no flags Details | Formatted Diff | Diff
Patch (4.07 KB, patch)
2013-03-29 08:20 PDT, Ilya Tikhonovsky
no flags Details | Formatted Diff | Diff
Patch (5.70 KB, patch)
2013-03-29 09:05 PDT, Ilya Tikhonovsky
pfeldman: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ilya Tikhonovsky 2013-03-29 07:02:45 PDT
Initially I made a fake anchor element and moved it according to the highlighted element position.
It is a hack and after http://trac.webkit.org/changeset/147209 I'm able to remove it.
Comment 1 Ilya Tikhonovsky 2013-03-29 07:04:44 PDT
Created attachment 195743 [details]
Patch
Comment 2 Andrey Lushnikov 2013-03-29 08:04:11 PDT
Comment on attachment 195743 [details]
Patch

What kind of behavior are you trying to archive? Changing popover's anchor location after returning it in |getPopoverAnchor| (by the means of |onMouseMove| method) seems to be hackish and might result in a popover located in a wrong place. Is it intentional? Why not just to create an anchorBox per every |getPopoverAnchor| call?
Comment 3 Andrey Lushnikov 2013-03-29 08:07:45 PDT
Comment on attachment 195743 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=195743&action=review

> Source/WebCore/inspector/front-end/FlameChart.js:459
> +        var canvasPaddingLeft = e.pageX - e.offsetX;
> +        var canvasPaddingTop = e.pageY - e.offsetY;

Is it really padding or offset?
Comment 4 Ilya Tikhonovsky 2013-03-29 08:20:19 PDT
Created attachment 195751 [details]
Patch
Comment 5 Ilya Tikhonovsky 2013-03-29 09:05:01 PDT
Created attachment 195754 [details]
Patch
Comment 6 Ilya Tikhonovsky 2013-03-29 09:05:37 PDT
(In reply to comment #2)
> (From update of attachment 195743 [details])
> What kind of behavior are you trying to archive? Changing popover's anchor location after returning it in |getPopoverAnchor| (by the means of |onMouseMove| method) seems to be hackish and might result in a popover located in a wrong place. Is it intentional? Why not just to create an anchorBox per every |getPopoverAnchor| call?

done.
Comment 7 Ilya Tikhonovsky 2013-03-29 09:45:53 PDT
Committed r147224: <http://trac.webkit.org/changeset/147224>