Bug 113576 - Web Inspector: Prompt before closing dirty tab.
Summary: Web Inspector: Prompt before closing dirty tab.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Vsevolod Vlasov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-29 06:36 PDT by Vsevolod Vlasov
Modified: 2013-03-29 10:05 PDT (History)
8 users (show)

See Also:


Attachments
Patch (9.63 KB, patch)
2013-03-29 06:57 PDT, Vsevolod Vlasov
pfeldman: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Vsevolod Vlasov 2013-03-29 06:36:33 PDT
We should never silently close tabs with dirty uiSourceCodes
Comment 1 Vsevolod Vlasov 2013-03-29 06:57:23 PDT
Created attachment 195741 [details]
Patch
Comment 2 Pavel Feldman 2013-03-29 10:01:38 PDT
Comment on attachment 195741 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=195741&action=review

> Source/WebCore/inspector/front-end/TabbedEditorContainer.js:190
> +        // FIXME(vsevik): this should be replaced with common Save/Discard/Cancel dialog.

Please remove vsevik.
Comment 3 Vsevolod Vlasov 2013-03-29 10:05:01 PDT
Committed r147226: <http://trac.webkit.org/changeset/147226>