NEW113566
Use (Pass)OwnPtr to reference ImageDecoder 
https://bugs.webkit.org/show_bug.cgi?id=113566
Summary Use (Pass)OwnPtr to reference ImageDecoder
Yury Semikhatsky
Reported 2013-03-29 03:13:33 PDT
In some places ImageDecoder is stored as raw pointer. OwnPtr/PassOwnPtr should be used instead.
Attachments
Patch (15.45 KB, patch)
2013-03-29 03:16 PDT, Yury Semikhatsky 		no flags
DetailsFormatted DiffDiff
Patch (15.15 KB, patch)
2013-03-29 04:03 PDT, Yury Semikhatsky 		no flags
DetailsFormatted DiffDiff
Patch (15.15 KB, patch)
2013-03-29 04:05 PDT, Yury Semikhatsky 		yurys: review-
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Yury Semikhatsky
Comment 1 2013-03-29 03:16:24 PDT
Created attachment 195714 [details] Patch
Build Bot
Comment 2 2013-03-29 03:48:07 PDT
Comment on attachment 195714 [details] Patch Attachment 195714 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-commit-queue.appspot.com/results/17242788
Pavel Feldman
Comment 3 2013-03-29 03:57:34 PDT
Comment on attachment 195714 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=195714&action=review > Source/WebCore/platform/graphics/ImageSource.cpp:49 > + : m_alphaOption(alphaOption) Extra space.
Yury Semikhatsky
Comment 4 2013-03-29 04:03:16 PDT
Created attachment 195718 [details] Patch
Yury Semikhatsky
Comment 5 2013-03-29 04:04:32 PDT
Comment on attachment 195714 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=195714&action=review >> Source/WebCore/platform/graphics/ImageSource.cpp:49 >> + : m_alphaOption(alphaOption) > > Extra space. Fixed.
Yury Semikhatsky
Comment 6 2013-03-29 04:05:32 PDT
Created attachment 195719 [details] Patch
Yury Semikhatsky
Comment 7 2013-03-29 04:42:34 PDT
(In reply to comment #6) > Created an attachment (id=195719) [details] > Patch This patch breaks CG as it provides its own implementation in ImageSourceCG.cpp
Note You need to log in before you can comment on or make changes to this bug.