RESOLVED FIXED 113563
Web Inspector: ability to use AnchorBox as an anchor for Popover 
https://bugs.webkit.org/show_bug.cgi?id=113563
Summary Web Inspector: ability to use AnchorBox as an anchor for Popover
Andrey Lushnikov
Reported 2013-03-29 02:40:53 PDT
Ability to use AnchorBox instead of Element as an anchor for Popover.
Attachments
Patch (4.00 KB, patch)
2013-03-29 02:43 PDT, Andrey Lushnikov 		no flags
DetailsFormatted DiffDiff
Patch (3.99 KB, patch)
2013-03-29 05:03 PDT, Andrey Lushnikov 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Andrey Lushnikov
Comment 1 2013-03-29 02:43:31 PDT
Created attachment 195711 [details] Patch
Eugene Klyuchnikov
Comment 2 2013-03-29 02:55:54 PDT
Comment on attachment 195711 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=195711&action=review > Source/WebCore/inspector/front-end/Popover.js:56 > + * @param {Element|AnchorBox} anchor Vsevolod wont accept this annotation =(
Andrey Lushnikov
Comment 3 2013-03-29 03:11:27 PDT
Comment on attachment 195711 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=195711&action=review >> Source/WebCore/inspector/front-end/Popover.js:56 >> + * @param {Element|AnchorBox} anchor > > Vsevolod wont accept this annotation =( How about a bet? :)
Ilya Tikhonovsky
Comment 4 2013-03-29 04:28:08 PDT
Comment on attachment 195711 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=195711&action=review >>> Source/WebCore/inspector/front-end/Popover.js:56 >>> + * @param {Element|AnchorBox} anchor >> >> Vsevolod wont accept this annotation =( > > How about a bet? :) You can move anchorElement.boxInWindow(window); call to the topmost functions like show and showView and implement another top level method showForBox In that case you will have better api.
Pavel Feldman
Comment 5 2013-03-29 04:46:18 PDT
Comment on attachment 195711 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=195711&action=review > Source/WebCore/inspector/front-end/Popover.js:159 > + var anchorBox = anchorElement.constructor === AnchorBox ? anchorElement : anchorElement.boxInWindow(window); Please use instanceof
Andrey Lushnikov
Comment 6 2013-03-29 05:03:17 PDT
Created attachment 195724 [details] Patch
WebKit Review Bot
Comment 7 2013-03-29 05:39:56 PDT
Comment on attachment 195724 [details] Patch Clearing flags on attachment: 195724 Committed r147209: <http://trac.webkit.org/changeset/147209>
WebKit Review Bot
Comment 8 2013-03-29 05:40:00 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.