Bug 113560 - Text representation of pseudo elements, '::-webkit-distributed', is wrong in CSSSelector::selectorText().
Summary: Text representation of pseudo elements, '::-webkit-distributed', is wrong in ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Hayato Ito
URL:
Keywords:
Depends on:
Blocks: 72352
  Show dependency treegraph
 
Reported: 2013-03-29 00:01 PDT by Hayato Ito
Modified: 2013-03-31 20:43 PDT (History)
7 users (show)

See Also:


Attachments
Fix. (3.62 KB, patch)
2013-03-29 03:27 PDT, Hayato Ito
no flags Details | Formatted Diff | Diff
Add a layouttest (5.96 KB, patch)
2013-03-31 18:17 PDT, Hayato Ito
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Hayato Ito 2013-03-29 00:01:33 PDT
The result of CSSSelector::selectorText() for '::-webkit-distributed(...)' is wrong.

e.g.

Given a rule of:

 'content::-webkit-distributed(div div:first-child)'

CSSSelector::selectorText() returns the following:

 'content::-webkit-distributed(div) div:first-child'
Comment 1 Hayato Ito 2013-03-29 03:27:22 PDT
Created attachment 195716 [details]
Fix.
Comment 2 Dimitri Glazkov (Google) 2013-03-29 07:53:07 PDT
Comment on attachment 195716 [details]
Fix.

View in context: https://bugs.webkit.org/attachment.cgi?id=195716&action=review

> Source/WebCore/ChangeLog:10
> +        No new tests, no behavior change for layout tests.

Are you sure? It seems that you could get at it with CSSStyleRule.selectorText.
Comment 3 Hayato Ito 2013-03-31 17:25:27 PDT
(In reply to comment #2)
> (From update of attachment 195716 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=195716&action=review
> 
> > Source/WebCore/ChangeLog:10
> > +        No new tests, no behavior change for layout tests.
> 
> Are you sure? It seems that you could get at it with CSSStyleRule.selectorText.

It seems we can write a test. Let me add a test.
Comment 4 Hayato Ito 2013-03-31 18:17:35 PDT
Created attachment 195914 [details]
Add a layouttest
Comment 5 WebKit Review Bot 2013-03-31 20:42:58 PDT
Comment on attachment 195914 [details]
Add a layouttest

Clearing flags on attachment: 195914

Committed r147295: <http://trac.webkit.org/changeset/147295>
Comment 6 WebKit Review Bot 2013-03-31 20:43:01 PDT
All reviewed patches have been landed.  Closing bug.