RESOLVED FIXED Bug 113549
AX: "video element controller" is an overly verbose default description for the playback controls; how about just "playback" 
https://bugs.webkit.org/show_bug.cgi?id=113549
Summary AX: "video element controller" is an overly verbose default description for t...
James Craig
Reported 2013-03-28 17:41:58 PDT
AX: "video element controller" is an overly verbose default description for the playback controls AXDescription is exposed as "video element controller", and VoiceOver speaks "video element controller toolbar item palette"; suggest changing "video element controller" to just "playback"
Attachments
patch (23.84 KB, application/octet-stream)
2013-03-29 17:35 PDT, James Craig 		no flags
Details
patch (23.84 KB, patch)
2013-03-29 17:36 PDT, James Craig 		no flags
DetailsFormatted DiffDiff
patch. previously missed a changelog. (23.97 KB, patch)
2013-03-29 17:41 PDT, James Craig 		no flags
DetailsFormatted DiffDiff
patch. removed references to "no new tests" because I updated existing test coverage. (23.91 KB, patch)
2013-04-01 10:41 PDT, James Craig 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2013-03-28 17:42:47 PDT
<rdar://problem/13532444>
James Craig
Comment 2 2013-03-28 18:18:03 PDT
Took a look at the source. There is an "audio element controller" role description, too. I plan to change these to "video playback" and "audio playback" to decrease the default verbosity in assistive technologies like VoiceOver. This will trigger some Loc string updates for about 40 languages.
James Craig
Comment 3 2013-03-29 17:35:56 PDT
Created attachment 195826 [details] patch
James Craig
Comment 4 2013-03-29 17:36:56 PDT
Created attachment 195827 [details] patch
James Craig
Comment 5 2013-03-29 17:41:06 PDT
Created attachment 195830 [details] patch. previously missed a changelog.
chris fleizach
Comment 6 2013-04-01 10:24:10 PDT
Comment on attachment 195830 [details] patch. previously missed a changelog. View in context: https://bugs.webkit.org/attachment.cgi?id=195830&action=review > Source/WebCore/ChangeLog:8 > + No new tests (OOPS!). Please remove the no new tests line, because you're updating existing tests
James Craig
Comment 7 2013-04-01 10:41:22 PDT
Created attachment 195990 [details] patch. removed references to "no new tests" because I updated existing test coverage.
WebKit Review Bot
Comment 8 2013-04-01 11:04:13 PDT
Comment on attachment 195990 [details] patch. removed references to "no new tests" because I updated existing test coverage. Clearing flags on attachment: 195990 Committed r147343: <http://trac.webkit.org/changeset/147343>
WebKit Review Bot
Comment 9 2013-04-01 11:04:19 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.