Bug 113544 - GraphicsLayerCA::recomputeVisibleRects() shouldn't actually set the visible rect
Summary: GraphicsLayerCA::recomputeVisibleRects() shouldn't actually set the visible rect
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-28 16:26 PDT by Simon Fraser (smfr)
Modified: 2013-04-09 14:41 PDT (History)
6 users (show)

See Also:


Attachments
Patch (8.62 KB, patch)
2013-03-28 16:31 PDT, Simon Fraser (smfr)
thorton: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2013-03-28 16:26:00 PDT
GraphicsLayerCA::recomputeVisibleRects() shouldn't actually set the visible rect
Comment 1 Simon Fraser (smfr) 2013-03-28 16:31:33 PDT
Created attachment 195675 [details]
Patch
Comment 2 Tim Horton 2013-03-28 16:39:08 PDT
Comment on attachment 195675 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=195675&action=review

> Source/WebCore/ChangeLog:14
> +        rect, it would need to make new tiles (which happens layer during a flush).

Layers on the brain?

> Source/WebCore/rendering/RenderLayerCompositor.h:140
> +    void noteVisibleRectChanged();

Is "note" usually used for things that actually affect behavior? (I have no idea).

didChangeVisibleRect?
Comment 3 Simon Fraser (smfr) 2013-04-09 14:41:11 PDT
http://trac.webkit.org/changeset/147186