Bug 113536 - Remove unnecessary 1 second sleep on windows from preprocessor.pm
Summary: Remove unnecessary 1 second sleep on windows from preprocessor.pm
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: James Robinson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-28 14:15 PDT by James Robinson
Modified: 2013-03-28 14:29 PDT (History)
4 users (show)

See Also:


Attachments
Patch (1.38 KB, patch)
2013-03-28 14:16 PDT, James Robinson
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description James Robinson 2013-03-28 14:15:54 PDT
Remove unnecessary 1 second sleep on windows from preprocessor.pm
Comment 1 James Robinson 2013-03-28 14:16:17 PDT
Created attachment 195639 [details]
Patch
Comment 2 Eric Seidel (no email) 2013-03-28 14:19:00 PDT
Comment on attachment 195639 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=195639&action=review

> Source/WebCore/ChangeLog:8
> +
> +        This regressed in 146661

You should comment that this made the build 12 minutes longer. :)  Sell it, man! :p
Comment 3 James Robinson 2013-03-28 14:19:33 PDT
(In reply to comment #2)
> (From update of attachment 195639 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=195639&action=review
> 
> > Source/WebCore/ChangeLog:8
> > +
> > +        This regressed in 146661
> 
> You should comment that this made the build 12 minutes longer. :)  Sell it, man! :p

I'm actually not 100% sure on that point - do we run the preprocessors in parallel?
Comment 4 Kentaro Hara 2013-03-28 14:21:45 PDT
Comment on attachment 195639 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=195639&action=review

>>> Source/WebCore/ChangeLog:8
>>> +        This regressed in 146661
>> 
>> You should comment that this made the build 12 minutes longer. :)  Sell it, man! :p
> 
> I'm actually not 100% sure on that point - do we run the preprocessors in parallel?

What was this sleep for? I couldn't find a rationale from a ChangeLog of r146661 (http://trac.webkit.org/changeset/146661).
Comment 5 James Robinson 2013-03-28 14:29:49 PDT
Committed r147157: <http://trac.webkit.org/changeset/147157>