REGRESSION: run-perf-tests --profiler seems to have broken
--profiler=pprof used to let you use the pprof profiler on linux for example. Now it no longer seems to work. Something (probably my fault) broke at some point in recent memory.
Not sure if the failure is the same than the one reported by Eric but it definitely does not work in GTK (and I guess that also in EFL) when using jhbuild to build.
The problem is that "perf --record" is never called because we just wrap the command with jhbuild-run.
Created attachment 245221 [details]
Created attachment 245224 [details]
Now with unit test
Comment on attachment 245224 [details]
View in context: https://bugs.webkit.org/attachment.cgi?id=245224&action=review
> + wrapper = 
Maybe a better name for this variable would be wrapper_arguments.
(In reply to comment #4)
> Comment on attachment 245224 [details]
> View in context:
> > Tools/Scripts/webkitpy/port/driver.py:228
> > + wrapper = 
> Maybe a better name for this variable would be wrapper_arguments.
Committed r179008: <http://trac.webkit.org/changeset/179008>