Bug 113526 - REGRESSION(r143102): Ignore table cell's height attribute when checking if containing block has auto height.
Summary: REGRESSION(r143102): Ignore table cell's height attribute when checking if co...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Major
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2013-03-28 12:14 PDT by zalan
Modified: 2013-03-29 00:35 PDT (History)
8 users (show)

See Also:


Attachments
test reduction (451 bytes, text/html)
2013-03-28 12:14 PDT, zalan
no flags Details
Patch (4.51 KB, patch)
2013-03-28 13:13 PDT, zalan
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from gce-cr-linux-07 for chromium-linux-x86_64 (621.81 KB, application/zip)
2013-03-28 14:19 PDT, WebKit Review Bot
no flags Details
Patch (4.67 KB, patch)
2013-03-28 14:26 PDT, zalan
no flags Details | Formatted Diff | Diff
Patch (5.60 KB, patch)
2013-03-28 15:20 PDT, zalan
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from gce-cr-linux-02 for chromium-linux-x86_64 (1.02 MB, application/zip)
2013-03-28 16:15 PDT, WebKit Review Bot
no flags Details
Archive of layout-test-results from webkit-ews-15 for mac-mountainlion-wk2 (588.26 KB, application/zip)
2013-03-28 22:50 PDT, Build Bot
no flags Details
Patch (5.60 KB, patch)
2013-03-28 23:53 PDT, zalan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2013-03-28 12:14:41 PDT
Created attachment 195614 [details]
test reduction

ssia

see attached test case
Comment 1 zalan 2013-03-28 12:15:32 PDT
<rdar://problem/13475928>
Comment 2 zalan 2013-03-28 13:13:54 PDT
Created attachment 195628 [details]
Patch
Comment 3 Antti Koivisto 2013-03-28 13:20:07 PDT
Comment on attachment 195628 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=195628&action=review

> Source/WebCore/ChangeLog:6
> +        It matches Firefox behaviour.

More importantly it matches our behavior before r143102, right? Would be good to mention that too. We don't really aspire to match Firefox exactly with all the table edge cases.

> Source/WebCore/rendering/RenderBoxModelObject.cpp:390
>  
> +    // Table cells violate what the CSS spec says to do with heights. Basically we
> +    // don't care if the cell specified a height or not.

Is the comment correct? I thought CSS spec specifically left some of this open?
Comment 4 WebKit Review Bot 2013-03-28 14:19:25 PDT
Comment on attachment 195628 [details]
Patch

Attachment 195628 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://webkit-commit-queue.appspot.com/results/17328409

New failing tests:
fast/replaced/iframe-with-percentage-height-within-table-with-table-cell-ignore-height.html
Comment 5 WebKit Review Bot 2013-03-28 14:19:28 PDT
Created attachment 195640 [details]
Archive of layout-test-results from gce-cr-linux-07 for chromium-linux-x86_64

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: gce-cr-linux-07  Port: chromium-linux-x86_64  Platform: Linux-3.3.8-gcg-201212281604-x86_64-with-GCEL-10.04-gcel_10.04
Comment 6 zalan 2013-03-28 14:26:42 PDT
Created attachment 195643 [details]
Patch
Comment 7 zalan 2013-03-28 15:20:27 PDT
Created attachment 195655 [details]
Patch
Comment 8 zalan 2013-03-28 15:21:15 PDT
Comment on attachment 195655 [details]
Patch

removing reftest case
Comment 9 WebKit Review Bot 2013-03-28 16:15:40 PDT
Comment on attachment 195655 [details]
Patch

Attachment 195655 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://webkit-commit-queue.appspot.com/results/17332217

New failing tests:
fast/replaced/iframe-with-percentage-height-within-table-with-table-cell-ignore-height.html
Comment 10 WebKit Review Bot 2013-03-28 16:15:44 PDT
Created attachment 195670 [details]
Archive of layout-test-results from gce-cr-linux-02 for chromium-linux-x86_64

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: gce-cr-linux-02  Port: chromium-linux-x86_64  Platform: Linux-3.3.8-gcg-201212281604-x86_64-with-GCEL-10.04-gcel_10.04
Comment 11 Build Bot 2013-03-28 16:33:31 PDT
Comment on attachment 195655 [details]
Patch

Attachment 195655 [details] did not pass win-ews (win):
Output: http://webkit-commit-queue.appspot.com/results/17313365
Comment 12 Build Bot 2013-03-28 22:50:23 PDT
Comment on attachment 195655 [details]
Patch

Attachment 195655 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-commit-queue.appspot.com/results/17335235

New failing tests:
fast/replaced/iframe-with-percentage-height-within-table-with-table-cell-ignore-height.html
Comment 13 Build Bot 2013-03-28 22:50:25 PDT
Created attachment 195699 [details]
Archive of layout-test-results from webkit-ews-15 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-15  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.2
Comment 14 zalan 2013-03-28 23:53:32 PDT
Created attachment 195702 [details]
Patch
Comment 15 WebKit Review Bot 2013-03-29 00:35:15 PDT
Comment on attachment 195702 [details]
Patch

Clearing flags on attachment: 195702

Committed r147199: <http://trac.webkit.org/changeset/147199>
Comment 16 WebKit Review Bot 2013-03-29 00:35:19 PDT
All reviewed patches have been landed.  Closing bug.