Bug 113526 – REGRESSION(r143102): Ignore table cell's height attribute when checking if containing block has auto height.

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[zalan]

Created attachment 195614 [details]
test reduction

ssia

see attached test case

[zalan]

<rdar://problem/13475928>

[zalan]

Created attachment 195628 [details]
Patch

[Antti Koivisto]

Comment on attachment 195628 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=195628&action=review

> Source/WebCore/ChangeLog:6
> +        It matches Firefox behaviour.

More importantly it matches our behavior before r143102, right? Would be good to mention that too. We don't really aspire to match Firefox exactly with all the table edge cases.

> Source/WebCore/rendering/RenderBoxModelObject.cpp:390
>  
> +    // Table cells violate what the CSS spec says to do with heights. Basically we
> +    // don't care if the cell specified a height or not.

Is the comment correct? I thought CSS spec specifically left some of this open?

[WebKit Review Bot]

Comment on attachment 195628 [details]
Patch

Attachment 195628 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://webkit-commit-queue.appspot.com/results/17328409

New failing tests:
fast/replaced/iframe-with-percentage-height-within-table-with-table-cell-ignore-height.html

[WebKit Review Bot]

Created attachment 195640 [details]
Archive of layout-test-results from gce-cr-linux-07 for chromium-linux-x86_64

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: gce-cr-linux-07  Port: chromium-linux-x86_64  Platform: Linux-3.3.8-gcg-201212281604-x86_64-with-GCEL-10.04-gcel_10.04

[zalan]

Created attachment 195643 [details]
Patch

[zalan]

Created attachment 195655 [details]
Patch

[zalan]

Comment on attachment 195655 [details]
Patch

removing reftest case

[WebKit Review Bot]

Comment on attachment 195655 [details]
Patch

Attachment 195655 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://webkit-commit-queue.appspot.com/results/17332217

New failing tests:
fast/replaced/iframe-with-percentage-height-within-table-with-table-cell-ignore-height.html

[WebKit Review Bot]

Created attachment 195670 [details]
Archive of layout-test-results from gce-cr-linux-02 for chromium-linux-x86_64

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: gce-cr-linux-02  Port: chromium-linux-x86_64  Platform: Linux-3.3.8-gcg-201212281604-x86_64-with-GCEL-10.04-gcel_10.04

[Build Bot]

Comment on attachment 195655 [details]
Patch

Attachment 195655 [details] did not pass win-ews (win):
Output: http://webkit-commit-queue.appspot.com/results/17313365

[Build Bot]

Comment on attachment 195655 [details]
Patch

Attachment 195655 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-commit-queue.appspot.com/results/17335235

New failing tests:
fast/replaced/iframe-with-percentage-height-within-table-with-table-cell-ignore-height.html

[Build Bot]

Created attachment 195699 [details]
Archive of layout-test-results from webkit-ews-15 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-15  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.2

[zalan]

Created attachment 195702 [details]
Patch

[WebKit Review Bot]

Comment on attachment 195702 [details]
Patch

Clearing flags on attachment: 195702

Committed r147199: <http://trac.webkit.org/changeset/147199>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.