Bug 113512 - [GStreamer] playback gets bumpy sometimes when on-disk buffering is slow
Summary: [GStreamer] playback gets bumpy sometimes when on-disk buffering is slow
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-28 10:09 PDT by Philippe Normand
Modified: 2013-03-29 04:28 PDT (History)
8 users (show)

See Also:


Attachments
patch (2.09 KB, patch)
2013-03-28 10:12 PDT, Philippe Normand
mrobinson: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Philippe Normand 2013-03-28 10:09:25 PDT
We should pause the pipeline when we get a buffering message that is not the final one. This is a strong advice from the GStreamer developers :)
Comment 1 Philippe Normand 2013-03-28 10:12:55 PDT
Created attachment 195589 [details]
patch
Comment 2 Martin Robinson 2013-03-28 10:17:49 PDT
Comment on attachment 195589 [details]
patch

Does the player automatically unpause?
Comment 3 Philippe Normand 2013-03-28 10:39:15 PDT
(In reply to comment #2)
> (From update of attachment 195589 [details])
> Does the player automatically unpause?

Yes when buffering is finished and also once the pipeline pre-rolled.
Comment 4 Martin Robinson 2013-03-28 10:43:06 PDT
Comment on attachment 195589 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=195589&action=review

> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:806
> +    if (!m_paused && (m_bufferingPercentage < 100)) {

You can probably dispense with the inner parenthesis here.
Comment 5 Philippe Normand 2013-03-29 04:28:35 PDT
Committed r147206: <http://trac.webkit.org/changeset/147206>