Bug 113497 - Web Inspector: Heap snapshots retained size falls out of the grid if column is too narrow
Summary: Web Inspector: Heap snapshots retained size falls out of the grid if column i...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Alexei Filippov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-28 03:32 PDT by Alexei Filippov
Modified: 2013-03-28 06:06 PDT (History)
9 users (show)

See Also:


Attachments
screenshot (17.45 KB, image/png)
2013-03-28 03:32 PDT, Alexei Filippov
no flags Details
Patch (1.35 KB, patch)
2013-03-28 03:36 PDT, Alexei Filippov
no flags Details | Formatted Diff | Diff
Patch (2.20 KB, patch)
2013-03-28 05:19 PDT, Alexei Filippov
no flags Details | Formatted Diff | Diff
Patch (2.24 KB, patch)
2013-03-28 05:44 PDT, Alexei Filippov
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexei Filippov 2013-03-28 03:32:46 PDT
Created attachment 195516 [details]
screenshot

See the screenshot.
Comment 1 Alexei Filippov 2013-03-28 03:36:34 PDT
Created attachment 195519 [details]
Patch
Comment 2 Build Bot 2013-03-28 04:51:59 PDT
Comment on attachment 195519 [details]
Patch

Attachment 195519 [details] did not pass win-ews (win):
Output: http://webkit-commit-queue.appspot.com/results/17353061
Comment 3 Pavel Feldman 2013-03-28 05:00:18 PDT
Comment on attachment 195519 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=195519&action=review

> Source/WebCore/inspector/front-end/heapProfiler.css:87
> +.heap-snapshot-view .data-grid td:not(.object-column) > div {

This rule seems to be too broad. Any div child of td? does it have a class name or identifier?
Comment 4 Alexei Filippov 2013-03-28 05:19:12 PDT
Created attachment 195537 [details]
Patch
Comment 5 Pavel Feldman 2013-03-28 05:35:52 PDT
Comment on attachment 195537 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=195537&action=review

> Source/WebCore/inspector/front-end/heapProfiler.css:127
> +.heap-snapshot-view .data-grid div.multiple-values {

please rename multiple-values to .head-shapshot-multiple-values. Otherwise it might clash with some other panels.
Comment 6 Alexei Filippov 2013-03-28 05:44:24 PDT
Created attachment 195540 [details]
Patch
Comment 7 Alexei Filippov 2013-03-28 05:44:40 PDT
Comment on attachment 195537 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=195537&action=review

>> Source/WebCore/inspector/front-end/heapProfiler.css:127
>> +.heap-snapshot-view .data-grid div.multiple-values {
> 
> please rename multiple-values to .head-shapshot-multiple-values. Otherwise it might clash with some other panels.

done
Comment 8 WebKit Review Bot 2013-03-28 06:06:00 PDT
Comment on attachment 195540 [details]
Patch

Clearing flags on attachment: 195540

Committed r147103: <http://trac.webkit.org/changeset/147103>
Comment 9 WebKit Review Bot 2013-03-28 06:06:04 PDT
All reviewed patches have been landed.  Closing bug.