Bug 113496 - Web Inspector: [Cookies] CookiesTable should integrate with DataGrid context menu.
Summary: Web Inspector: [Cookies] CookiesTable should integrate with DataGrid context ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Eugene Klyuchnikov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-28 03:28 PDT by Eugene Klyuchnikov
Modified: 2013-03-28 23:29 PDT (History)
9 users (show)

See Also:

Attachments
Patch (5.91 KB, patch)
2013-03-28 03:34 PDT, Eugene Klyuchnikov 		no flags Details | Formatted Diff | Diff
Patch (6.11 KB, patch)
2013-03-28 22:33 PDT, Eugene Klyuchnikov 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eugene Klyuchnikov 2013-03-28 03:28:52 PDT 
In recent path CookiesTable added context menu listener on DataGrid element to override behavior.

Integrating with DataGrid instead of overriding looks better.

Actually that patch is reduced version of patch that was waiting for better back-end cookies management.
Comment 1 Eugene Klyuchnikov 2013-03-28 03:34:40 PDT 
Created attachment 195517 [details]
Patch
Comment 2 Pavel Feldman 2013-03-28 05:02:11 PDT 
Comment on attachment 195517 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=195517&action=review

> Source/WebCore/inspector/front-end/CookiesTable.js:281
> +    _refresh: function() {

{ on the next line.

> Source/WebCore/inspector/front-end/CookiesTable.js:282
> +        this._refreshCallback && this._refreshCallback();

We never do this, please use explicit if.

> Source/WebCore/inspector/front-end/DataGrid.js:33
> + * @param {?function(!WebInspector.ContextMenu, WebInspector.DataGridNode)=} contextMenuCallback

We don't use nullable optional fields. Please remove ? from here and above.
Comment 3 Eugene Klyuchnikov 2013-03-28 22:28:21 PDT 
Comment on attachment 195517 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=195517&action=review

>> Source/WebCore/inspector/front-end/CookiesTable.js:281
>> +    _refresh: function() {
> 
> { on the next line.

oops. fixed

>> Source/WebCore/inspector/front-end/CookiesTable.js:282
>> +        this._refreshCallback && this._refreshCallback();
> 
> We never do this, please use explicit if.

Done.

>> Source/WebCore/inspector/front-end/DataGrid.js:33
>> + * @param {?function(!WebInspector.ContextMenu, WebInspector.DataGridNode)=} contextMenuCallback
> 
> We don't use nullable optional fields. Please remove ? from here and above.

OK
Comment 4 Eugene Klyuchnikov 2013-03-28 22:33:12 PDT 
Created attachment 195697 [details]
Patch
Comment 5 WebKit Review Bot 2013-03-28 23:29:42 PDT 
Comment on attachment 195697 [details]
Patch

Clearing flags on attachment: 195697

Committed r147198: <http://trac.webkit.org/changeset/147198>
Comment 6 WebKit Review Bot 2013-03-28 23:29:45 PDT 
All reviewed patches have been landed.  Closing bug.