RESOLVED FIXED113496
Web Inspector: [Cookies] CookiesTable should integrate with DataGrid context menu. 
https://bugs.webkit.org/show_bug.cgi?id=113496
Summary Web Inspector: [Cookies] CookiesTable should integrate with DataGrid context ...
Eugene Klyuchnikov
Reported 2013-03-28 03:28:52 PDT
In recent path CookiesTable added context menu listener on DataGrid element to override behavior. Integrating with DataGrid instead of overriding looks better. Actually that patch is reduced version of patch that was waiting for better back-end cookies management.
Attachments
Patch (5.91 KB, patch)
2013-03-28 03:34 PDT, Eugene Klyuchnikov 		no flags
DetailsFormatted DiffDiff
Patch (6.11 KB, patch)
2013-03-28 22:33 PDT, Eugene Klyuchnikov 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Eugene Klyuchnikov
Comment 1 2013-03-28 03:34:40 PDT
Created attachment 195517 [details] Patch
Pavel Feldman
Comment 2 2013-03-28 05:02:11 PDT
Comment on attachment 195517 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=195517&action=review > Source/WebCore/inspector/front-end/CookiesTable.js:281 > + _refresh: function() { { on the next line. > Source/WebCore/inspector/front-end/CookiesTable.js:282 > + this._refreshCallback && this._refreshCallback(); We never do this, please use explicit if. > Source/WebCore/inspector/front-end/DataGrid.js:33 > + * @param {?function(!WebInspector.ContextMenu, WebInspector.DataGridNode)=} contextMenuCallback We don't use nullable optional fields. Please remove ? from here and above.
Eugene Klyuchnikov
Comment 3 2013-03-28 22:28:21 PDT
Comment on attachment 195517 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=195517&action=review >> Source/WebCore/inspector/front-end/CookiesTable.js:281 >> + _refresh: function() { > > { on the next line. oops. fixed >> Source/WebCore/inspector/front-end/CookiesTable.js:282 >> + this._refreshCallback && this._refreshCallback(); > > We never do this, please use explicit if. Done. >> Source/WebCore/inspector/front-end/DataGrid.js:33 >> + * @param {?function(!WebInspector.ContextMenu, WebInspector.DataGridNode)=} contextMenuCallback > > We don't use nullable optional fields. Please remove ? from here and above. OK
Eugene Klyuchnikov
Comment 4 2013-03-28 22:33:12 PDT
Created attachment 195697 [details] Patch
WebKit Review Bot
Comment 5 2013-03-28 23:29:42 PDT
Comment on attachment 195697 [details] Patch Clearing flags on attachment: 195697 Committed r147198: <http://trac.webkit.org/changeset/147198>
WebKit Review Bot
Comment 6 2013-03-28 23:29:45 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.