SSIA.
Created attachment 195513 [details] Patch
Comment on attachment 195513 [details] Patch Attachment 195513 [details] did not pass win-ews (win): Output: http://webkit-commit-queue.appspot.com/results/17353054
Created attachment 195673 [details] Patch
Comment on attachment 195673 [details] Patch Attachment 195673 [details] did not pass win-ews (win): Output: http://webkit-commit-queue.appspot.com/results/17356061
Comment on attachment 195673 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=195673&action=review > LayoutTests/platform/efl/TestExpectations:-1535 > -webkit.org/b/100424 editing/selection/user-select-all-selection.html [ Failure ] Don't you need to rebaseline this test case ? When I run this test with your patch, this test was failed.
(In reply to comment #5) > (From update of attachment 195673 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=195673&action=review > > > LayoutTests/platform/efl/TestExpectations:-1535 > > -webkit.org/b/100424 editing/selection/user-select-all-selection.html [ Failure ] > > Don't you need to rebaseline this test case ? When I run this test with your patch, this test was failed. When I tested the case in my local, it has passed. I have double checked in other PC, too. Could you let me know how tested the case?
Comment on attachment 195673 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=195673&action=review LGTM. >>> LayoutTests/platform/efl/TestExpectations:-1535 >>> -webkit.org/b/100424 editing/selection/user-select-all-selection.html [ Failure ] >> >> Don't you need to rebaseline this test case ? When I run this test with your patch, this test was failed. > > When I tested the case in my local, it has passed. I have double checked in other PC, too. Could you let me know how tested the case? Hmm, there was something wrong. This test is passed on my pc now. Sorry for noise.
(In reply to comment #4) > (From update of attachment 195673 [details]) > Attachment 195673 [details] did not pass win-ews (win): > Output: http://webkit-commit-queue.appspot.com/results/17356061 Unrelated error with this patch.
Comment on attachment 195673 [details] Patch Clearing flags on attachment: 195673 Committed r147306: <http://trac.webkit.org/changeset/147306>
All reviewed patches have been landed. Closing bug.