RESOLVED FIXED Bug 113486
Web Inspector: [Network] Split business logic and presentation for initiator column. 
https://bugs.webkit.org/show_bug.cgi?id=113486
Summary Web Inspector: [Network] Split business logic and presentation for initiator ...
Eugene Klyuchnikov
Reported 2013-03-28 00:59:50 PDT
Currently business logic and presentation are mixed. This prevents making cell renderer static and applying viewport rendering, because initiator sorting function depends on data written when cell is rendered. In this patch initiator information is extracted in separate method.
Attachments
Patch (10.20 KB, patch)
2013-03-28 02:14 PDT, Eugene Klyuchnikov 		no flags
DetailsFormatted DiffDiff
Patch (10.01 KB, patch)
2013-03-29 00:51 PDT, Eugene Klyuchnikov 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Eugene Klyuchnikov
Comment 1 2013-03-28 02:14:55 PDT
Created attachment 195505 [details] Patch
Pavel Feldman
Comment 2 2013-03-28 02:48:56 PDT
Comment on attachment 195505 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=195505&action=review > Source/WebCore/inspector/front-end/NetworkPanel.js:2475 > + var aInitiator = WebInspector.NetworkDataGridNode.buildInitiatorInfo(a._request); You are creating it while sorting.
Eugene Klyuchnikov
Comment 3 2013-03-28 03:01:10 PDT
Comment on attachment 195505 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=195505&action=review >> Source/WebCore/inspector/front-end/NetworkPanel.js:2475 >> + var aInitiator = WebInspector.NetworkDataGridNode.buildInitiatorInfo(a._request); > > You are creating it while sorting. In first (unpublished) version of patch I've created/cached it in NetworkRequest. But I thought you wouldn't accept it. So, would you like if initiatorInfo will be cached in NetworkRequest instance?
Eugene Klyuchnikov
Comment 4 2013-03-29 00:51:06 PDT
Created attachment 195705 [details] Patch
WebKit Review Bot
Comment 5 2013-04-02 22:58:46 PDT
Comment on attachment 195705 [details] Patch Clearing flags on attachment: 195705 Committed r147519: <http://trac.webkit.org/changeset/147519>
WebKit Review Bot
Comment 6 2013-04-02 22:58:50 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.