WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
Bug 113484
[CMAKE] Build fix after
r147052
https://bugs.webkit.org/show_bug.cgi?id=113484
Summary
[CMAKE] Build fix after r147052
Jaehun Lim
Reported
2013-03-28 00:04:26 PDT
Add "${WEBKIT2_DIR}/Shared/Plugins" to the include path for TestWebKitAPI, WebKitTestRunner.
Attachments
Patch
(1.79 KB, patch)
2013-03-28 00:34 PDT
,
Jaehun Lim
no flags
Details
Formatted Diff
Diff
Patch
(1.79 KB, patch)
2013-03-28 00:52 PDT
,
Jaehun Lim
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Jaehun Lim
Comment 1
2013-03-28 00:34:30 PDT
Created
attachment 195494
[details]
Patch
WebKit Review Bot
Comment 2
2013-03-28 00:48:49 PDT
Comment on
attachment 195494
[details]
Patch Rejecting
attachment 195494
[details]
from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=webkit-commit-queue.appspot.com', '--bot-id=gce-cq-04', 'validate-changelog', '--non-interactive', 195494, '--port=chromium-xvfb']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue /mnt/git/webkit-commit-queue/Tools/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output:
http://webkit-commit-queue.appspot.com/results/17336173
Jaehun Lim
Comment 3
2013-03-28 00:52:22 PDT
Created
attachment 195495
[details]
Patch
WebKit Review Bot
Comment 4
2013-03-28 01:23:19 PDT
Comment on
attachment 195495
[details]
Patch Clearing flags on attachment: 195495 Committed
r147081
: <
http://trac.webkit.org/changeset/147081
>
WebKit Review Bot
Comment 5
2013-03-28 01:23:22 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug