Bug 113480 - Use git's --find-renames with webkit-patch
Summary: Use git's --find-renames with webkit-patch
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-27 22:46 PDT by Claudio Saavedra
Modified: 2023-12-25 10:02 PST (History)
4 users (show)

See Also:

Attachments
Patch (1.64 KB, patch)
2013-03-27 22:46 PDT, Claudio Saavedra 		csaavedra: review-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Claudio Saavedra 2013-03-27 22:46:25 PDT 
Use git's --find-renames with webkit-patch
Comment 1 Claudio Saavedra 2013-03-27 22:46:58 PDT 
Created attachment 195485 [details]
Patch
Comment 2 WebKit Review Bot 2013-03-27 22:51:17 PDT 
Attachment 195485 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/ChangeLog', u'Tools/Scripts/webkitpy/common/checkout/scm/git.py']" exit_code: 1
Traceback (most recent call last):
  File "Tools/Scripts/check-webkit-style", line 48, in <module>
    sys.exit(CheckWebKitStyle().main())
  File "/mnt/git/webkit-style-queue/Tools/Scripts/webkitpy/style/main.py", line 152, in main
    patch = host.scm().create_patch(options.git_commit, changed_files=changed_files)
  File "/mnt/git/webkit-style-queue/Tools/Scripts/webkitpy/common/checkout/scm/git.py", line 299, in create_patch
    return self.prepend_svn_revision(self.run(command, decode_output=False, cwd=self.checkout_root))
  File "/mnt/git/webkit-style-queue/Tools/Scripts/webkitpy/common/checkout/scm/scm.py", line 78, in run
    decode_output=decode_output)
  File "/mnt/git/webkit-style-queue/Tools/Scripts/webkitpy/common/system/executive.py", line 432, in run_command
    (error_handler or self.default_error_handler)(script_error)
  File "/mnt/git/webkit-style-queue/Tools/Scripts/webkitpy/common/system/executive.py", line 350, in default_error_handler
    raise error
webkitpy.common.system.executive.ScriptError: Failed to run "['git', 'diff', '--binary', '--no-color', '--no-ext-diff', '--full-index', '--find-renames', '-O/mnt/git/webkit-style-queue/Tools/Scripts/webkitpy/common/config/orderfile', u'7dd9a6610f1e48f98adcc73e0b3052ffe3440c1b', '--', 'Tools/ChangeLog', 'Tools/Scripts/webkitpy/common/checkout/scm/git.py']" exit_code: 129 cwd: /mnt/git/webkit-style-queue


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Claudio Saavedra 2013-03-27 23:34:29 PDT 
OK, it's not that simple it seems. Apparently --find-renames can guess some renames wrongly. There is already a discussion related to why this was explicitly disabled in bug 48075. In any case, right now patches moving files that are generated from diff are really hard to review, so I think we should aim to fix this somehow eventually.
Comment 4 Anne van Kesteren 2023-12-25 10:02:23 PST 
I think this has become obsolete due to GitHub. But please reopen if you disagree.