Bug 113460 - Web Inspector: Update test expectation for resource-har-conversion.html
Summary: Web Inspector: Update test expectation for resource-har-conversion.html
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 113586 113677
  Show dependency treegraph
 
Reported: 2013-03-27 17:12 PDT by Seokju Kwon
Modified: 2013-03-31 23:24 PDT (History)
10 users (show)

See Also:


Attachments
Patch (2.71 KB, patch)
2013-03-27 17:13 PDT, Seokju Kwon
no flags Details | Formatted Diff | Diff
Patch (8.73 KB, patch)
2013-03-28 16:28 PDT, Seokju Kwon
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Seokju Kwon 2013-03-27 17:12:35 PDT
The value of pageref and title had been changed after r105596.
-use page ids, not document URLs in HAR entries to refer to pages
-use page URL as a title field of a HAR page
Comment 1 Seokju Kwon 2013-03-27 17:13:44 PDT
Created attachment 195442 [details]
Patch
Comment 2 Andrey Kosyakov 2013-03-28 04:43:06 PDT
LGTM
Comment 3 Andrey Kosyakov 2013-03-28 04:46:26 PDT
I think you might also want to remove suppressions in TestExpectations for this test. Also, please check platform-specific expectation overrides.
Comment 4 Vsevolod Vlasov 2013-03-28 04:47:20 PDT
Comment on attachment 195442 [details]
Patch

As Andrey said please update test expectations before landing.
Comment 5 Seokju Kwon 2013-03-28 16:26:19 PDT
(In reply to comment #4)
> (From update of attachment 195442 [details])
> As Andrey said please update test expectations before landing.

Andrey Kosyakov, Vsevolod Vlasov
Thank you for review. :)

I will override platform-specific expectation as well.
But almost platforms have different bug number in TestExpectations.
So I will take a look at it after landing this patch.
Comment 6 Seokju Kwon 2013-03-28 16:28:10 PDT
Created attachment 195674 [details]
Patch
Comment 7 WebKit Review Bot 2013-03-29 08:08:05 PDT
Comment on attachment 195674 [details]
Patch

Clearing flags on attachment: 195674

Committed r147219: <http://trac.webkit.org/changeset/147219>
Comment 8 WebKit Review Bot 2013-03-29 08:08:09 PDT
All reviewed patches have been landed.  Closing bug.