Bug 113447 - [BlackBerry] Don't use WebKit thread scale information in WebPageCompositor
Summary: [BlackBerry] Don't use WebKit thread scale information in WebPageCompositor
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jakob Petsovits
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-27 14:57 PDT by Jakob Petsovits
Modified: 2013-03-28 11:42 PDT (History)
5 users (show)

See Also:

Attachments
Patch (10.80 KB, patch)
2013-03-27 15:03 PDT, Jakob Petsovits 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jakob Petsovits 2013-03-27 14:57:01 PDT 
WebPageCompositor and the related BackingStore member function compositeContents() are using WebKit thread data on the user interface thread, without synchronization primitives or anything. That's bad and should be fixed.

Potential threading problems can be avoided by moving from WebPage members and mapToTransformed() to the web page client's userInterfaceViewportAccessor().
As part of this cleaning effort, the WebPageCompositor's render() method is changed to now take document instead of pixel coordinates.
Comment 1 Jakob Petsovits 2013-03-27 15:03:04 PDT 
Created attachment 195404 [details]
Patch
Comment 2 Arvid Nilsson 2013-03-27 23:00:27 PDT 
Comment on attachment 195404 [details]
Patch

Looks great!
Comment 3 Rob Buis 2013-03-28 07:06:19 PDT 
Comment on attachment 195404 [details]
Patch

LGTM.
Comment 4 WebKit Review Bot 2013-03-28 11:42:23 PDT 
Comment on attachment 195404 [details]
Patch

Clearing flags on attachment: 195404

Committed r147136: <http://trac.webkit.org/changeset/147136>
Comment 5 WebKit Review Bot 2013-03-28 11:42:26 PDT 
All reviewed patches have been landed.  Closing bug.