Bug 113442 – Cache preprocessor results when generating bindings

• Status: RESOLVED
• Resolution: DUPLICATE
• Component: New Bugs

[Tony Chang]

Cache preprocessor results when generating bindings

[Tony Chang]

Created attachment 195397 [details]
Patch

[Kentaro Hara]

Comment on attachment 195397 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=195397&action=review

LGTM. Thanks for fixing the issue.

> Source/WebCore/bindings/scripts/preprocessor.pm:67
> +    return @{$preprocessorCache{$fileName}} if $preprocessorCache{$fileName};

Nit: You can write this at the beginning of the method.

[Nico Weber]

Comment on attachment 195397 [details]
Patch

Cool, thanks!

Might want to mention that this is safe because defines etc don't change between preprocessor invocations.

[Tony Chang]

Created attachment 195398 [details]
Patch for landing

[Tony Chang]

Comment on attachment 195398 [details]
Patch for landing

Making sure all the bots are green before landing.

[Tony Chang]

(In reply to comment #3)
> (From update of attachment 195397 [details])
> Cool, thanks!
> 
> Might want to mention that this is safe because defines etc don't change between preprocessor invocations.

Yeah.  I also considered somehow adding the command line and @defines to the hash key, but I don't know perl that well.  Suggestions welcome.

[Kentaro Hara]

(In reply to comment #6)
> (In reply to comment #3)
> > (From update of attachment 195397 [details] [details])
> > Cool, thanks!
> > 
> > Might want to mention that this is safe because defines etc don't change between preprocessor invocations.
> 
> Yeah.  I also considered somehow adding the command line and @defines to the hash key, but I don't know perl that well.  Suggestions welcome.

$defines and $preprocessor are simple strings, so I guess you can simply concatenate them with $fileName.

[Tony Chang]

Created attachment 195401 [details]
Patch

[Tony Chang]

(In reply to comment #7)
> (In reply to comment #6)
> > (In reply to comment #3)
> > > (From update of attachment 195397 [details] [details] [details])
> > > Cool, thanks!
> > > 
> > > Might want to mention that this is safe because defines etc don't change between preprocessor invocations.
> > 
> > Yeah.  I also considered somehow adding the command line and @defines to the hash key, but I don't know perl that well.  Suggestions welcome.
> 
> $defines and $preprocessor are simple strings, so I guess you can simply concatenate them with $fileName.

Good idea, that works.

[Tony Chang]

Scott's patch is better.

*** This bug has been marked as a duplicate of bug 113448 ***