Bug 113435 - BlackBerry Committer Email Updates
Summary: BlackBerry Committer Email Updates
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-27 13:03 PDT by Ming Xie
Modified: 2013-03-28 09:31 PDT (History)
5 users (show)

See Also:


Attachments
Patch (10.22 KB, patch)
2013-03-27 13:10 PDT, Ming Xie
no flags Details | Formatted Diff | Diff
Updated Patch (10.22 KB, patch)
2013-03-27 13:36 PDT, Ming Xie
rwlbuis: review+
rwlbuis: commit-queue+
Details | Formatted Diff | Diff
Patch (10.23 KB, patch)
2013-03-27 13:51 PDT, Ming Xie
rwlbuis: review+
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff
Updated with ChangeLogs (10.95 KB, patch)
2013-03-28 09:06 PDT, Ming Xie
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ming Xie 2013-03-27 13:03:51 PDT
Add the @blackberry.com email address for all our BlackBerry WebKit committers.

Also remove the email addresses that are no longer valid.
Comment 1 Ming Xie 2013-03-27 13:10:27 PDT
Created attachment 195382 [details]
Patch

(I'm not a committer yet :)
Comment 2 WebKit Review Bot 2013-03-27 13:28:58 PDT
Attachment 195382 [details] did not pass style-queue:

Traceback (most recent call last):
  File "/mnt/git/webkit-style-queue/Tools/Scripts/webkit-patch", line 44, in <module>
    from webkitpy.tool.main import WebKitPatch
  File "/mnt/git/webkit-style-queue/Tools/Scripts/webkitpy/tool/main.py", line 37, in <module>
    from webkitpy.common.host import Host
  File "/mnt/git/webkit-style-queue/Tools/Scripts/webkitpy/common/host.py", line 34, in <module>
    from webkitpy.common.checkout import Checkout
  File "/mnt/git/webkit-style-queue/Tools/Scripts/webkitpy/common/checkout/__init__.py", line 3, in <module>
    from .checkout import Checkout
  File "/mnt/git/webkit-style-queue/Tools/Scripts/webkitpy/common/checkout/checkout.py", line 32, in <module>
    from webkitpy.common.checkout.changelog import ChangeLog, parse_bug_id_from_changelog
  File "/mnt/git/webkit-style-queue/Tools/Scripts/webkitpy/common/checkout/changelog.py", line 36, in <module>
    from webkitpy.common.config.committers import CommitterList
  File "/mnt/git/webkit-style-queue/Tools/Scripts/webkitpy/common/config/committers.py", line 232, in <module>
    Committer("Arvid Nilsson", "anilsson@blackberry.com", "anilsson@rim.com", "anilsson"),
TypeError: __init__() takes at most 4 arguments (5 given)


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Ming Xie 2013-03-27 13:36:28 PDT
Created attachment 195387 [details]
Updated Patch
Comment 4 Rob Buis 2013-03-27 13:45:13 PDT
Comment on attachment 195387 [details]
Updated Patch

Retrying.
Comment 5 WebKit Review Bot 2013-03-27 13:48:19 PDT
Attachment 195387 [details] did not pass style-queue:

Traceback (most recent call last):
  File "/mnt/git/webkit-style-queue/Tools/Scripts/webkit-patch", line 44, in <module>
    from webkitpy.tool.main import WebKitPatch
  File "/mnt/git/webkit-style-queue/Tools/Scripts/webkitpy/tool/main.py", line 37, in <module>
    from webkitpy.common.host import Host
  File "/mnt/git/webkit-style-queue/Tools/Scripts/webkitpy/common/host.py", line 34, in <module>
    from webkitpy.common.checkout import Checkout
  File "/mnt/git/webkit-style-queue/Tools/Scripts/webkitpy/common/checkout/__init__.py", line 3, in <module>
    from .checkout import Checkout
  File "/mnt/git/webkit-style-queue/Tools/Scripts/webkitpy/common/checkout/checkout.py", line 32, in <module>
    from webkitpy.common.checkout.changelog import ChangeLog, parse_bug_id_from_changelog
  File "/mnt/git/webkit-style-queue/Tools/Scripts/webkitpy/common/checkout/changelog.py", line 36, in <module>
    from webkitpy.common.config.committers import CommitterList
  File "/mnt/git/webkit-style-queue/Tools/Scripts/webkitpy/common/config/committers.py", line 353, in <module>
    Committer("Konrad Piascik", "kpiascik@blackberry.com", "kpiascik@rim.com", "kpiascik"),
TypeError: __init__() takes at most 4 arguments (5 given)


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 6 Ming Xie 2013-03-27 13:51:38 PDT
Created attachment 195389 [details]
Patch

Try again. Sorry!
Comment 7 Rob Buis 2013-03-27 13:54:31 PDT
Comment on attachment 195389 [details]
Patch

Thirs time is a charm.
Comment 8 WebKit Review Bot 2013-03-27 17:22:18 PDT
Comment on attachment 195389 [details]
Patch

Rejecting attachment 195389 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=webkit-commit-queue.appspot.com', '--bot-id=gce-cq-03', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 195389, '--port=chromium-xvfb']" exit_code: 2 cwd: /mnt/git/webkit-commit-queue

Last 500 characters of output:
t/git/webkit-commit-queue/Source/WebKit/chromium/v8 --revision 14075 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
55>At revision 14075.

________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'

________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
Updating webkit projects from gyp files...

Full output: http://webkit-commit-queue.appspot.com/results/17340084
Comment 9 Ming Xie 2013-03-27 19:05:49 PDT
I don't see how my patch triggers this failure.

Rob, do you know?

(In reply to comment #8)
> (From update of attachment 195389 [details])
> Rejecting attachment 195389 [details] from commit-queue.
> 
> Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=webkit-commit-queue.appspot.com', '--bot-id=gce-cq-03', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 195389, '--port=chromium-xvfb']" exit_code: 2 cwd: /mnt/git/webkit-commit-queue
> 
> Last 500 characters of output:
> t/git/webkit-commit-queue/Source/WebKit/chromium/v8 --revision 14075 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
> 55>At revision 14075.
> 
> ________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
> 
> ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
> Updating webkit projects from gyp files...
> 
> Full output: http://webkit-commit-queue.appspot.com/results/17340084
Comment 10 Rob Buis 2013-03-28 07:10:38 PDT
Ming, I think it needs a ChangeLog. Also it may be more consistent to put a [BlackBerry] tag in bug title since it only effects our port.

(In reply to comment #9)
> I don't see how my patch triggers this failure.
> 
> Rob, do you know?
> 
> (In reply to comment #8)
> > (From update of attachment 195389 [details] [details])
> > Rejecting attachment 195389 [details] [details] from commit-queue.
> > 
> > Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=webkit-commit-queue.appspot.com', '--bot-id=gce-cq-03', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 195389, '--port=chromium-xvfb']" exit_code: 2 cwd: /mnt/git/webkit-commit-queue
> > 
> > Last 500 characters of output:
> > t/git/webkit-commit-queue/Source/WebKit/chromium/v8 --revision 14075 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
> > 55>At revision 14075.
> > 
> > ________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
> > 
> > ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
> > Updating webkit projects from gyp files...
> > 
> > Full output: http://webkit-commit-queue.appspot.com/results/17340084
Comment 11 Ming Xie 2013-03-28 09:06:51 PDT
Created attachment 195582 [details]
Updated with ChangeLogs

Always forget about the Changelog... Sorry! :(
Comment 12 Rob Buis 2013-03-28 09:11:58 PDT
Comment on attachment 195582 [details]
Updated with ChangeLogs

Retrying.
Comment 13 WebKit Review Bot 2013-03-28 09:31:14 PDT
Comment on attachment 195582 [details]
Updated with ChangeLogs

Clearing flags on attachment: 195582

Committed r147124: <http://trac.webkit.org/changeset/147124>
Comment 14 WebKit Review Bot 2013-03-28 09:31:18 PDT
All reviewed patches have been landed.  Closing bug.