Bug 113435 – BlackBerry Committer Email Updates

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Ming Xie]

Add the @blackberry.com email address for all our BlackBerry WebKit committers.

Also remove the email addresses that are no longer valid.

[Ming Xie]

Created attachment 195382 [details]
Patch

(I'm not a committer yet :)

[WebKit Review Bot]

Attachment 195382 [details] did not pass style-queue:

Traceback (most recent call last):
  File "/mnt/git/webkit-style-queue/Tools/Scripts/webkit-patch", line 44, in <module>
    from webkitpy.tool.main import WebKitPatch
  File "/mnt/git/webkit-style-queue/Tools/Scripts/webkitpy/tool/main.py", line 37, in <module>
    from webkitpy.common.host import Host
  File "/mnt/git/webkit-style-queue/Tools/Scripts/webkitpy/common/host.py", line 34, in <module>
    from webkitpy.common.checkout import Checkout
  File "/mnt/git/webkit-style-queue/Tools/Scripts/webkitpy/common/checkout/__init__.py", line 3, in <module>
    from .checkout import Checkout
  File "/mnt/git/webkit-style-queue/Tools/Scripts/webkitpy/common/checkout/checkout.py", line 32, in <module>
    from webkitpy.common.checkout.changelog import ChangeLog, parse_bug_id_from_changelog
  File "/mnt/git/webkit-style-queue/Tools/Scripts/webkitpy/common/checkout/changelog.py", line 36, in <module>
    from webkitpy.common.config.committers import CommitterList
  File "/mnt/git/webkit-style-queue/Tools/Scripts/webkitpy/common/config/committers.py", line 232, in <module>
    Committer("Arvid Nilsson", "[e-mail]", "[e-mail]", "anilsson"),
TypeError: __init__() takes at most 4 arguments (5 given)


If any of these errors are false positives, please file a bug against check-webkit-style.

[Ming Xie]

Created attachment 195387 [details]
Updated Patch

[Rob Buis]

Comment on attachment 195387 [details]
Updated Patch

Retrying.

[WebKit Review Bot]

Attachment 195387 [details] did not pass style-queue:

Traceback (most recent call last):
  File "/mnt/git/webkit-style-queue/Tools/Scripts/webkit-patch", line 44, in <module>
    from webkitpy.tool.main import WebKitPatch
  File "/mnt/git/webkit-style-queue/Tools/Scripts/webkitpy/tool/main.py", line 37, in <module>
    from webkitpy.common.host import Host
  File "/mnt/git/webkit-style-queue/Tools/Scripts/webkitpy/common/host.py", line 34, in <module>
    from webkitpy.common.checkout import Checkout
  File "/mnt/git/webkit-style-queue/Tools/Scripts/webkitpy/common/checkout/__init__.py", line 3, in <module>
    from .checkout import Checkout
  File "/mnt/git/webkit-style-queue/Tools/Scripts/webkitpy/common/checkout/checkout.py", line 32, in <module>
    from webkitpy.common.checkout.changelog import ChangeLog, parse_bug_id_from_changelog
  File "/mnt/git/webkit-style-queue/Tools/Scripts/webkitpy/common/checkout/changelog.py", line 36, in <module>
    from webkitpy.common.config.committers import CommitterList
  File "/mnt/git/webkit-style-queue/Tools/Scripts/webkitpy/common/config/committers.py", line 353, in <module>
    Committer("Konrad Piascik", "[e-mail]", "[e-mail]", "kpiascik"),
TypeError: __init__() takes at most 4 arguments (5 given)


If any of these errors are false positives, please file a bug against check-webkit-style.

[Ming Xie]

Created attachment 195389 [details]
Patch

Try again. Sorry!

[Rob Buis]

Comment on attachment 195389 [details]
Patch

Thirs time is a charm.

[WebKit Review Bot]

Comment on attachment 195389 [details]
Patch

Rejecting attachment 195389 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=webkit-commit-queue.appspot.com', '--bot-id=gce-cq-03', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 195389, '--port=chromium-xvfb']" exit_code: 2 cwd: /mnt/git/webkit-commit-queue

Last 500 characters of output:
t/git/webkit-commit-queue/Source/WebKit/chromium/v8 --revision 14075 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
55>At revision 14075.

________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'

________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
Updating webkit projects from gyp files...

Full output: http://webkit-commit-queue.appspot.com/results/17340084

[Ming Xie]

I don't see how my patch triggers this failure.

Rob, do you know?

(In reply to comment #8)
> (From update of attachment 195389 [details])
> Rejecting attachment 195389 [details] from commit-queue.
> 
> Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=webkit-commit-queue.appspot.com', '--bot-id=gce-cq-03', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 195389, '--port=chromium-xvfb']" exit_code: 2 cwd: /mnt/git/webkit-commit-queue
> 
> Last 500 characters of output:
> t/git/webkit-commit-queue/Source/WebKit/chromium/v8 --revision 14075 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
> 55>At revision 14075.
> 
> ________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
> 
> ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
> Updating webkit projects from gyp files...
> 
> Full output: http://webkit-commit-queue.appspot.com/results/17340084

[Rob Buis]

Ming, I think it needs a ChangeLog. Also it may be more consistent to put a [BlackBerry] tag in bug title since it only effects our port.

(In reply to comment #9)
> I don't see how my patch triggers this failure.
> 
> Rob, do you know?
> 
> (In reply to comment #8)
> > (From update of attachment 195389 [details] [details])
> > Rejecting attachment 195389 [details] [details] from commit-queue.
> > 
> > Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=webkit-commit-queue.appspot.com', '--bot-id=gce-cq-03', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 195389, '--port=chromium-xvfb']" exit_code: 2 cwd: /mnt/git/webkit-commit-queue
> > 
> > Last 500 characters of output:
> > t/git/webkit-commit-queue/Source/WebKit/chromium/v8 --revision 14075 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
> > 55>At revision 14075.
> > 
> > ________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
> > 
> > ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
> > Updating webkit projects from gyp files...
> > 
> > Full output: http://webkit-commit-queue.appspot.com/results/17340084

[Ming Xie]

Created attachment 195582 [details]
Updated with ChangeLogs

Always forget about the Changelog... Sorry! :(

[Rob Buis]

Comment on attachment 195582 [details]
Updated with ChangeLogs

Retrying.

[WebKit Review Bot]

Comment on attachment 195582 [details]
Updated with ChangeLogs

Clearing flags on attachment: 195582

Committed r147124: <http://trac.webkit.org/changeset/147124>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.