WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
113423
[BlackBerry] Handle EXIF orientation for ImageDocuments
https://bugs.webkit.org/show_bug.cgi?id=113423
Summary
[BlackBerry] Handle EXIF orientation for ImageDocuments
Chris H-C
Reported
2013-03-27 10:42:15 PDT
This'll work too if we decide to turn on the setting to support exif orientation on <img>, but for now it's off.
Attachments
Patch
(5.37 KB, patch)
2013-03-27 10:57 PDT
,
Chris H-C
no flags
Details
Formatted Diff
Diff
Patch
(5.25 KB, patch)
2013-03-27 11:44 PDT
,
Chris H-C
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Chris H-C
Comment 1
2013-03-27 10:57:14 PDT
Created
attachment 195355
[details]
Patch
Jeff Rogers
Comment 2
2013-03-27 11:40:53 PDT
Comment on
attachment 195355
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=195355&action=review
> Source/WebCore/ChangeLog:7 > + Informally Reviewed by NOBODY (OOPS!).
You will need to update or remove the informally reviewed line.
> Source/WebCore/ChangeLog:15 > + calls to include BlendMode.
You can probably leave this comment out.
> Source/WebCore/platform/graphics/blackberry/ImageBlackBerry.cpp:165 > +
This looks fine.
Chris H-C
Comment 3
2013-03-27 11:44:57 PDT
Created
attachment 195368
[details]
Patch
Rob Buis
Comment 4
2013-03-27 11:49:05 PDT
Comment on
attachment 195368
[details]
Patch Looks good.
Build Bot
Comment 5
2013-03-27 16:55:54 PDT
Comment on
attachment 195368
[details]
Patch
Attachment 195368
[details]
did not pass win-ews (win): Output:
http://webkit-commit-queue.appspot.com/results/17216963
WebKit Review Bot
Comment 6
2013-03-28 07:02:29 PDT
Comment on
attachment 195368
[details]
Patch Clearing flags on attachment: 195368 Committed
r147110
: <
http://trac.webkit.org/changeset/147110
>
WebKit Review Bot
Comment 7
2013-03-28 07:02:33 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug