Bug 113423 - [BlackBerry] Handle EXIF orientation for ImageDocuments
Summary: [BlackBerry] Handle EXIF orientation for ImageDocuments
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris H-C
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-27 10:42 PDT by Chris H-C
Modified: 2013-03-28 07:02 PDT (History)
8 users (show)

See Also:


Attachments
Patch (5.37 KB, patch)
2013-03-27 10:57 PDT, Chris H-C
no flags Details | Formatted Diff | Diff
Patch (5.25 KB, patch)
2013-03-27 11:44 PDT, Chris H-C
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris H-C 2013-03-27 10:42:15 PDT
This'll work too if we decide to turn on the setting to support exif orientation on <img>, but for now it's off.
Comment 1 Chris H-C 2013-03-27 10:57:14 PDT
Created attachment 195355 [details]
Patch
Comment 2 Jeff Rogers 2013-03-27 11:40:53 PDT
Comment on attachment 195355 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=195355&action=review

> Source/WebCore/ChangeLog:7
> +        Informally Reviewed by NOBODY (OOPS!).

You will need to update or remove the informally reviewed line.

> Source/WebCore/ChangeLog:15
> +        calls to include BlendMode.

You can probably leave this comment out.

> Source/WebCore/platform/graphics/blackberry/ImageBlackBerry.cpp:165
> +

This looks fine.
Comment 3 Chris H-C 2013-03-27 11:44:57 PDT
Created attachment 195368 [details]
Patch
Comment 4 Rob Buis 2013-03-27 11:49:05 PDT
Comment on attachment 195368 [details]
Patch

Looks good.
Comment 5 Build Bot 2013-03-27 16:55:54 PDT
Comment on attachment 195368 [details]
Patch

Attachment 195368 [details] did not pass win-ews (win):
Output: http://webkit-commit-queue.appspot.com/results/17216963
Comment 6 WebKit Review Bot 2013-03-28 07:02:29 PDT
Comment on attachment 195368 [details]
Patch

Clearing flags on attachment: 195368

Committed r147110: <http://trac.webkit.org/changeset/147110>
Comment 7 WebKit Review Bot 2013-03-28 07:02:33 PDT
All reviewed patches have been landed.  Closing bug.