Bug 113406 - [Mac] Text track menu items sometimes labeled incorrectly
Summary: [Mac] Text track menu items sometimes labeled incorrectly
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Eric Carlson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2013-03-27 07:11 PDT by Eric Carlson
Modified: 2013-03-27 11:32 PDT (History)
5 users (show)

See Also:

Attachments
Proposed patch (5.22 KB, patch)
2013-03-27 07:15 PDT, Eric Carlson 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Carlson 2013-03-27 07:11:56 PDT 
Text track menu items with both 'label' and 'srclang' attributes are not correct.
Comment 1 Eric Carlson 2013-03-27 07:15:37 PDT 
Created attachment 195311 [details]
Proposed patch
Comment 2 Radar WebKit Bug Importer 2013-03-27 07:15:58 PDT 
<rdar://problem/13515337>
Comment 3 Jer Noble 2013-03-27 09:48:22 PDT 
Comment on attachment 195311 [details]
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=195311&action=review

r+, with nit:

> Source/WebCore/page/CaptionUserPreferencesMac.mm:541
> +        if (language.isEmpty() || label.contains(language)) {
> +            displayName.append(label);
> +        } else {

Unnecessary braces.
Comment 4 Eric Carlson 2013-03-27 11:32:03 PDT 
https://trac.webkit.org/r147000