Bug 113403 – [EFL][jhbuild] Evas fails to build when Wayland is present on the system

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Raphael Kubo da Costa (:rakuco)]

As of Evas 1.7.5, when Wayland is detected on the system, support for both Wayland SHM and Wayland EGL is automatically enabled in autoconf.

The code, however, seems to depend on a few other flags which must be explicitly enabled (namely, --enable-gl-flavor-gles, --enable-gles-variety-sgx and --enable-gl-xcb). Otherwise, we get this error:

  evas_wl_main.c: In function 'eng_window_new':
  evas_wl_main.c:197:18: error: 'Evas_Engine_GL_Context' has no member named 'egldisp'

The flags we need to pass are the ones mentioned in bug 112522, which we closed as WONTFIX. The problem here is different though, and according to one of the Wayland-EFL developers enabling those flags even if the system does not have Wayland or GL support should be fine.

[Raphael Kubo da Costa (:rakuco)]

(In reply to comment #0)
> The problem here is different though, and according to one of the Wayland-EFL developers enabling those flags even if the system does not have Wayland or GL support should be fine.

Kalyan, can you double-check that what I wrote above makes sense?

[Raphael Kubo da Costa (:rakuco)]

Created attachment 195304 [details]
Patch

[Kalyan]

Comment on attachment 195304 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=195304&action=review

> Tools/efl/jhbuild.modules:197
> +             autogenargs="--enable-gl-xcb --enable-gles-variety-sgx --enable-gl-flavor-gles">

This would be an issue if the underlying system doesn't support EGL i.e Nvidia drivers. Have you checked this ??

I also remember that I couldn't get evas build (when libwayland-dev in my system) as it checked for some non existent packages. I had to remove wayland related stuff before I could get it compiled. I can cross check this one again though.

[Kalyan]

Comment on attachment 195304 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=195304&action=review

>> Tools/efl/jhbuild.modules:197
>> +             autogenargs="--enable-gl-xcb --enable-gles-variety-sgx --enable-gl-flavor-gles">
> 
> This would be an issue if the underlying system doesn't support EGL i.e Nvidia drivers. Have you checked this ??
> 
> I also remember that I couldn't get evas build (when libwayland-dev in my system) as it checked for some non existent packages. I had to remove wayland related stuff before I could get it compiled. I can cross check this one again though.

k, first issue might be obsolete as per your earlier comments.

[Raphael Kubo da Costa (:rakuco)]

Created attachment 195329 [details]
Patch

[Raphael Kubo da Costa (:rakuco)]

(In reply to comment #5)
> Created an attachment (id=195329) [details]
> Patch

Reverse approach now: building with those additional flags made MiniBrowser simply crash or hang when being launched.

It's safer to just disable Wayland while we don't investigate and/or add proper support for it.

[Kalyan]

LGTM

[Raphael Kubo da Costa (:rakuco)]

Committed r146988: <http://trac.webkit.org/changeset/146988>