Bug 113392 - [Mac] Use fontName rather than familyName for internal fonts
Summary: [Mac] Use fontName rather than familyName for internal fonts
Alias: None
Product: WebKit
Classification: Unclassified
Component: Text (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dean Jackson
Keywords: InRadar
Depends on:
Reported: 2013-03-27 04:52 PDT by Dean Jackson
Modified: 2013-03-27 10:52 PDT (History)
5 users (show)

See Also:

Patch (4.51 KB, patch)
2013-03-27 04:56 PDT, Dean Jackson
enrica: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dean Jackson 2013-03-27 04:52:15 PDT
Some internal fonts for OS X are not listed in availableFontFamilies, which means that WebCore fails to find them. In these cases we should look for the fontName, rather than the familyName.

Comment 1 Dean Jackson 2013-03-27 04:56:32 PDT
Created attachment 195279 [details]
Comment 2 Build Bot 2013-03-27 06:40:02 PDT
Comment on attachment 195279 [details]

Attachment 195279 [details] did not pass win-ews (win):
Output: http://webkit-commit-queue.appspot.com/results/17257428
Comment 3 Enrica Casucci 2013-03-27 08:04:55 PDT
Comment on attachment 195279 [details]

Looks good
Comment 4 Dean Jackson 2013-03-27 10:43:30 PDT
Not sure what is up with the windows tests:
svg/dom/SVGScriptElement/script-change-externalResourcesRequired-while-loading.svg -> failed
Comment 5 Dean Jackson 2013-03-27 10:48:19 PDT
Since the files changed here aren't even compiled on Windows, it seems like a misleading result. I'll keep an eye on the test bots.
Comment 6 Dean Jackson 2013-03-27 10:52:08 PDT
Committed r146995: <http://trac.webkit.org/changeset/146995>