Bug 113376 - Web Inspector: update Timeline.TimelineEvent definition to include DOM counters and native memory stats
Summary: Web Inspector: update Timeline.TimelineEvent definition to include DOM counte...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Yury Semikhatsky
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-27 02:00 PDT by Yury Semikhatsky
Modified: 2013-03-27 07:25 PDT (History)
12 users (show)

See Also:


Attachments
Patch (7.71 KB, patch)
2013-03-27 02:05 PDT, Yury Semikhatsky
no flags Details | Formatted Diff | Diff
Patch (1.64 KB, patch)
2013-03-27 05:43 PDT, Yury Semikhatsky
vsevik: review+
vsevik: commit-queue+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yury Semikhatsky 2013-03-27 02:00:49 PDT
The event already can contain optional DOM counters and native memory stats. This should be reflected in Inspector.json
Comment 1 Yury Semikhatsky 2013-03-27 02:05:39 PDT
Created attachment 195250 [details]
Patch
Comment 2 Yury Semikhatsky 2013-03-27 02:31:42 PDT
Committed r146975: <http://trac.webkit.org/changeset/146975>
Comment 3 Yury Semikhatsky 2013-03-27 05:43:46 PDT
Reopening to attach new patch.
Comment 4 Yury Semikhatsky 2013-03-27 05:43:49 PDT
Created attachment 195290 [details]
Patch
Comment 5 Yury Semikhatsky 2013-03-27 05:45:08 PDT
(In reply to comment #4)
> Created an attachment (id=195290) [details]
> Patch

Previous change caused assertion failure in debug mode in timeline tests(http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20%28dbg%29/builds/7509/steps/webkit_tests/logs/stdio). This is a fix.
Comment 6 Yury Semikhatsky 2013-03-27 07:25:42 PDT
Committed r146982: <http://trac.webkit.org/changeset/146982>