Bug 113348 - Web Inspector: [CodeMirror] CodeMirrorTextEditor.highlightRange has bugs
Summary: Web Inspector: [CodeMirror] CodeMirrorTextEditor.highlightRange has bugs
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Andrey Lushnikov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-26 15:05 PDT by Andrey Lushnikov
Modified: 2013-03-27 01:15 PDT (History)
9 users (show)

See Also:

Attachments
Patch (1.89 KB, patch)
2013-03-26 15:09 PDT, Andrey Lushnikov 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrey Lushnikov 2013-03-26 15:05:29 PDT 
CodeMirrorTextEditor.highlightRange has bugs:
- it doesn't highlight last letter of selection (because the it assumes the range to be exclusive on the right end)
- it doesn't provide any way to set up some css class with border
Comment 1 Andrey Lushnikov 2013-03-26 15:09:17 PDT 
Created attachment 195172 [details]
Patch
Comment 2 WebKit Review Bot 2013-03-27 01:15:03 PDT 
Comment on attachment 195172 [details]
Patch

Clearing flags on attachment: 195172

Committed r146972: <http://trac.webkit.org/changeset/146972>
Comment 3 WebKit Review Bot 2013-03-27 01:15:06 PDT 
All reviewed patches have been landed.  Closing bug.