Bug 113341 – Web Inspector: [Mac] Support dock-to-right

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Timothy Hatcher]

It is time to support dock to right on Mac.

[Timothy Hatcher]

<rdar://problem/10368152>

[Timothy Hatcher]

Created attachment 195166 [details]
Proposed Change

This is likely going to brake some builds. Throwing to the EWS to find out what needs tweaked. The changes should be all ready to review still.

[WebKit Review Bot]

Attachment 195166 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/WebCore.exp.in', u'Source/WebCore/inspector/InspectorFrontendClient.h', u'Source/WebCore/inspector/InspectorFrontendClientLocal.cpp', u'Source/WebCore/inspector/InspectorFrontendClientLocal.h', u'Source/WebCore/inspector/InspectorFrontendHost.cpp', u'Source/WebCore/inspector/InspectorFrontendHost.h', u'Source/WebCore/inspector/InspectorFrontendHost.idl', u'Source/WebCore/inspector/front-end/InspectorFrontendHostStub.js', u'Source/WebCore/inspector/front-end/externs.js', u'Source/WebCore/testing/Internals.cpp', u'Source/WebKit/mac/ChangeLog', u'Source/WebKit/mac/Resources/Dock.pdf', u'Source/WebKit/mac/WebCoreSupport/WebInspectorClient.h', u'Source/WebKit/mac/WebCoreSupport/WebInspectorClient.mm', u'Source/WebKit/mac/WebInspector/WebInspectorFrontend.mm', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/Resources/Dock.pdf', u'Source/WebKit2/Resources/DockBottom.pdf', u'Source/WebKit2/Resources/DockRight.pdf', u'Source/WebKit2/Shared/WebPreferencesStore.h', u'Source/WebKit2/UIProcess/WebInspectorProxy.cpp', u'Source/WebKit2/UIProcess/WebInspectorProxy.h', u'Source/WebKit2/UIProcess/WebInspectorProxy.messages.in', u'Source/WebKit2/UIProcess/mac/WebInspectorProxyMac.mm', u'Source/WebKit2/WebKit2.xcodeproj/project.pbxproj', u'Source/WebKit2/WebProcess/WebCoreSupport/WebInspectorFrontendClient.cpp', u'Source/WebKit2/WebProcess/WebCoreSupport/WebInspectorFrontendClient.h', u'Source/WebKit2/WebProcess/WebPage/WebInspector.cpp', u'Source/WebKit2/WebProcess/WebPage/WebInspector.h', u'Source/WebKit2/WebProcess/WebPage/WebInspector.messages.in']" exit_code: 1
Source/WebCore/inspector/InspectorFrontendHost.h:68:  The parameter name "width" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 1 in 27 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Early Warning System Bot]

Comment on attachment 195166 [details]
Proposed Change

Attachment 195166 [details] did not pass qt-ews (qt):
Output: http://webkit-commit-queue.appspot.com/results/17251643

[WebKit Review Bot]

Comment on attachment 195166 [details]
Proposed Change

Attachment 195166 [details] did not pass cr-linux-debug-ews (chromium-xvfb):
Output: http://webkit-commit-queue.appspot.com/results/17296304

[WebKit Review Bot]

Comment on attachment 195166 [details]
Proposed Change

Attachment 195166 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://webkit-commit-queue.appspot.com/results/17290734

[Early Warning System Bot]

Comment on attachment 195166 [details]
Proposed Change

Attachment 195166 [details] did not pass qt-wk2-ews (qt):
Output: http://webkit-commit-queue.appspot.com/results/17334092

[kov's GTK+ EWS bot]

Comment on attachment 195166 [details]
Proposed Change

Attachment 195166 [details] did not pass gtk-ews (gtk):
Output: http://webkit-commit-queue.appspot.com/results/17132987

[Peter Beverloo (cr-android ews)]

Comment on attachment 195166 [details]
Proposed Change

Attachment 195166 [details] did not pass cr-android-ews (chromium-android):
Output: http://webkit-commit-queue.appspot.com/results/17246582

[Joseph Pecoraro]

Comment on attachment 195166 [details]
Proposed Change

View in context: https://bugs.webkit.org/attachment.cgi?id=195166&action=review

Looks good to me assuming other builds get fixed. There will need to be a WK2 Owner to r+ the WK2 parts.

> Source/WebCore/inspector/InspectorFrontendClientLocal.h:108
> +    void setAttachedWindow(DockSide);

This will break Qt WK1, which also extends InspectorFrontendClientLocal:
WebKit/qt/WebCoreSupport/InspectorClientQt.cpp

The changes would be minor.

[Timothy Hatcher]

Created attachment 195176 [details]
Proposed Change (Take 2)

With some build fixes.

[WebKit Review Bot]

Attachment 195176 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/WebCore.exp.in', u'Source/WebCore/inspector/InspectorFrontendClient.h', u'Source/WebCore/inspector/InspectorFrontendClientLocal.cpp', u'Source/WebCore/inspector/InspectorFrontendClientLocal.h', u'Source/WebCore/inspector/InspectorFrontendHost.cpp', u'Source/WebCore/inspector/InspectorFrontendHost.h', u'Source/WebCore/inspector/InspectorFrontendHost.idl', u'Source/WebCore/inspector/front-end/InspectorFrontendHostStub.js', u'Source/WebCore/inspector/front-end/externs.js', u'Source/WebCore/testing/Internals.cpp', u'Source/WebKit/chromium/src/InspectorFrontendClientImpl.cpp', u'Source/WebKit/chromium/src/InspectorFrontendClientImpl.h', u'Source/WebKit/efl/WebCoreSupport/InspectorClientEfl.cpp', u'Source/WebKit/efl/WebCoreSupport/InspectorClientEfl.h', u'Source/WebKit/gtk/WebCoreSupport/InspectorClientGtk.cpp', u'Source/WebKit/gtk/WebCoreSupport/InspectorClientGtk.h', u'Source/WebKit/mac/ChangeLog', u'Source/WebKit/mac/Resources/Dock.pdf', u'Source/WebKit/mac/WebCoreSupport/WebInspectorClient.h', u'Source/WebKit/mac/WebCoreSupport/WebInspectorClient.mm', u'Source/WebKit/mac/WebInspector/WebInspectorFrontend.mm', u'Source/WebKit/qt/WebCoreSupport/InspectorClientQt.cpp', u'Source/WebKit/qt/WebCoreSupport/InspectorClientQt.h', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/Resources/Dock.pdf', u'Source/WebKit2/Resources/DockBottom.pdf', u'Source/WebKit2/Resources/DockRight.pdf', u'Source/WebKit2/Shared/WebPreferencesStore.h', u'Source/WebKit2/UIProcess/WebInspectorProxy.cpp', u'Source/WebKit2/UIProcess/WebInspectorProxy.h', u'Source/WebKit2/UIProcess/WebInspectorProxy.messages.in', u'Source/WebKit2/UIProcess/mac/WebInspectorProxyMac.mm', u'Source/WebKit2/WebKit2.xcodeproj/project.pbxproj', u'Source/WebKit2/WebProcess/WebCoreSupport/WebInspectorFrontendClient.cpp', u'Source/WebKit2/WebProcess/WebCoreSupport/WebInspectorFrontendClient.h', u'Source/WebKit2/WebProcess/WebPage/WebInspector.cpp', u'Source/WebKit2/WebProcess/WebPage/WebInspector.h', u'Source/WebKit2/WebProcess/WebPage/WebInspector.messages.in']" exit_code: 1
Source/WebCore/inspector/InspectorFrontendHost.h:68:  The parameter name "width" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 1 in 35 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Early Warning System Bot]

Comment on attachment 195176 [details]
Proposed Change (Take 2)

Attachment 195176 [details] did not pass qt-wk2-ews (qt):
Output: http://webkit-commit-queue.appspot.com/results/17329187

[Build Bot]

Comment on attachment 195176 [details]
Proposed Change (Take 2)

Attachment 195176 [details] did not pass win-ews (win):
Output: http://webkit-commit-queue.appspot.com/results/17232829

[EFL EWS Bot]

Comment on attachment 195176 [details]
Proposed Change (Take 2)

Attachment 195176 [details] did not pass efl-ews (efl):
Output: http://webkit-commit-queue.appspot.com/results/17141970

[WebKit Review Bot]

Comment on attachment 195176 [details]
Proposed Change (Take 2)

Attachment 195176 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://webkit-commit-queue.appspot.com/results/17258543

New failing tests:
fast/js/dfg-inline-resolve.html

[WebKit Review Bot]

Created attachment 195192 [details]
Archive of layout-test-results from gce-cr-linux-03 for chromium-linux-x86_64

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: gce-cr-linux-03  Port: chromium-linux-x86_64  Platform: Linux-3.3.8-gcg-201212281604-x86_64-with-GCEL-10.04-gcel_10.04

[Timothy Hatcher]

Created attachment 195302 [details]
Proposed Change (Take 3)

[WebKit Review Bot]

Attachment 195302 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/WebCore.exp.in', u'Source/WebCore/inspector/InspectorFrontendClient.h', u'Source/WebCore/inspector/InspectorFrontendClientLocal.cpp', u'Source/WebCore/inspector/InspectorFrontendClientLocal.h', u'Source/WebCore/inspector/InspectorFrontendHost.cpp', u'Source/WebCore/inspector/InspectorFrontendHost.h', u'Source/WebCore/inspector/InspectorFrontendHost.idl', u'Source/WebCore/inspector/front-end/InspectorFrontendHostStub.js', u'Source/WebCore/inspector/front-end/externs.js', u'Source/WebCore/testing/Internals.cpp', u'Source/WebKit/chromium/src/InspectorFrontendClientImpl.cpp', u'Source/WebKit/chromium/src/InspectorFrontendClientImpl.h', u'Source/WebKit/efl/WebCoreSupport/InspectorClientEfl.cpp', u'Source/WebKit/efl/WebCoreSupport/InspectorClientEfl.h', u'Source/WebKit/gtk/WebCoreSupport/InspectorClientGtk.cpp', u'Source/WebKit/gtk/WebCoreSupport/InspectorClientGtk.h', u'Source/WebKit/mac/ChangeLog', u'Source/WebKit/mac/Resources/Dock.pdf', u'Source/WebKit/mac/WebCoreSupport/WebInspectorClient.h', u'Source/WebKit/mac/WebCoreSupport/WebInspectorClient.mm', u'Source/WebKit/mac/WebInspector/WebInspectorFrontend.mm', u'Source/WebKit/qt/WebCoreSupport/InspectorClientQt.cpp', u'Source/WebKit/qt/WebCoreSupport/InspectorClientQt.h', u'Source/WebKit/win/WebCoreSupport/WebInspectorClient.cpp', u'Source/WebKit/win/WebCoreSupport/WebInspectorClient.h', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/Resources/Dock.pdf', u'Source/WebKit2/Resources/DockBottom.pdf', u'Source/WebKit2/Resources/DockRight.pdf', u'Source/WebKit2/Shared/WebPreferencesStore.h', u'Source/WebKit2/UIProcess/WebInspectorProxy.cpp', u'Source/WebKit2/UIProcess/WebInspectorProxy.h', u'Source/WebKit2/UIProcess/WebInspectorProxy.messages.in', u'Source/WebKit2/UIProcess/mac/WebInspectorProxyMac.mm', u'Source/WebKit2/UIProcess/qt/WebInspectorProxyQt.cpp', u'Source/WebKit2/WebKit2.xcodeproj/project.pbxproj', u'Source/WebKit2/WebProcess/WebCoreSupport/WebInspectorFrontendClient.cpp', u'Source/WebKit2/WebProcess/WebCoreSupport/WebInspectorFrontendClient.h', u'Source/WebKit2/WebProcess/WebPage/WebInspector.cpp', u'Source/WebKit2/WebProcess/WebPage/WebInspector.h', u'Source/WebKit2/WebProcess/WebPage/WebInspector.messages.in']" exit_code: 1
Source/WebKit/win/WebCoreSupport/WebInspectorClient.cpp:47:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 38 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[EFL EWS Bot]

Comment on attachment 195302 [details]
Proposed Change (Take 3)

Attachment 195302 [details] did not pass efl-ews (efl):
Output: http://webkit-commit-queue.appspot.com/results/17288664

[kov's GTK+ EWS bot]

Comment on attachment 195302 [details]
Proposed Change (Take 3)

Attachment 195302 [details] did not pass gtk-ews (gtk):
Output: http://webkit-commit-queue.appspot.com/results/17327165

[Timothy Hatcher]

Created attachment 195319 [details]
Proposed Change (Take 4)

[kov's GTK+ EWS bot]

Comment on attachment 195319 [details]
Proposed Change (Take 4)

Attachment 195319 [details] did not pass gtk-ews (gtk):
Output: http://webkit-commit-queue.appspot.com/results/17340034

[Timothy Hatcher]

Can someone from GTK and EFL ports explain the build failures? I'm exporting __ZN7WebCore28InspectorFrontendClientLocal25changeAttachedWindowWidthEj and it works fine on other ports.

[Timothy Hatcher]

Looks like GTK is the only issue now. Windows TBD.

[Build Bot]

Comment on attachment 195319 [details]
Proposed Change (Take 4)

Attachment 195319 [details] did not pass win-ews (win):
Output: http://webkit-commit-queue.appspot.com/results/17253575

[Timothy Hatcher]

Created attachment 195356 [details]
Proposed Change (Take 5)

Win build fix. Still need advice on GTK's build failure.

[Zan Dobersek]

The GTK build is failing due to the undefined InspectorFrontendClientLocal::changeAttachedWindowWidth, to fix that you should list the related symbol (__ZN7WebCore28InspectorFrontendClientLocal25changeAttachedWindowWidthEj) in Source/autotools/symbols.filter.

Thanks for not breaking the GTK build!

[Timothy Hatcher]

Created attachment 195375 [details]
Proposed Change (Take 6)

[Anders Carlsson]

Comment on attachment 195375 [details]
Proposed Change (Take 6)

WebKit 2 parts look good.

[Joseph Pecoraro]

Comment on attachment 195375 [details]
Proposed Change (Take 6)

r=me, looks like you might be missing a few ChangeLog entires for the recent port build fixes.

[Ryosuke Niwa]

Landed in http://trac.webkit.org/changeset/147004.
Build fixes landed in http://trac.webkit.org/changeset/147005, http://trac.webkit.org/changeset/147007, and http://trac.webkit.org/changeset/147009.