Bug 113334 - [BlackBerry] RSS reader filter swallows headers when there is no body
Summary: [BlackBerry] RSS reader filter swallows headers when there is no body
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Page Loading (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other Unspecified
: P2 Normal
Assignee: Joe Mason
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-26 12:30 PDT by Joe Mason
Modified: 2013-03-26 13:07 PDT (History)
4 users (show)

See Also:

Attachments
fix (1.28 KB, patch)
2013-03-26 12:41 PDT, Joe Mason 		no flags Details | Formatted Diff | Diff
fix (3.18 KB, patch)
2013-03-26 12:43 PDT, Joe Mason 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joe Mason 2013-03-26 12:30:31 PDT 
When receiving an HTTP response that has a Content-Type header such as text/xml, but no body, RSSFilterStream::notifyHeadersReceived reads the Content-Type as "potential RSS", and calls saveHeaders. It expects to sniff the body in notifyDataReceived to see if it's RSS, and then call sendSavedHeaders to pass on the headers.

But notifyDataReceived is never called since there's no body, so neither is sendSavedHeaders. The result is that NetworkJob sees "notifyStatusReceived; notifyClose" instead of "notifyStatusReceived; notifyHeadersReceived; notifyClose".
Comment 1 Joe Mason 2013-03-26 12:41:17 PDT 
Created attachment 195145 [details]
fix
Comment 2 Joe Mason 2013-03-26 12:43:55 PDT 
Created attachment 195146 [details]
fix

Right patch this time
Comment 3 Rob Buis 2013-03-26 12:47:18 PDT 
Comment on attachment 195146 [details]
fix

LGTM.
Comment 4 WebKit Review Bot 2013-03-26 13:06:58 PDT 
Comment on attachment 195146 [details]
fix

Clearing flags on attachment: 195146

Committed r146922: <http://trac.webkit.org/changeset/146922>
Comment 5 WebKit Review Bot 2013-03-26 13:07:01 PDT 
All reviewed patches have been landed.  Closing bug.