Bug 113324 - Revision for the internal jhbuild is too old
Summary: Revision for the internal jhbuild is too old
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mario Sanchez Prada
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-26 10:40 PDT by Mario Sanchez Prada
Modified: 2013-03-27 17:00 PDT (History)
4 users (show)

See Also:


Attachments
Patch proposal (1.34 KB, patch)
2013-03-26 10:45 PDT, Mario Sanchez Prada
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mario Sanchez Prada 2013-03-26 10:40:02 PDT
Today I found WebKitGTK is using a pretty old version of jhbuild for the internal libs, which has an important bug that makes the process to fail during the "make install" stage, in case it founds a symlink to a directory after moving it from the temporary place under _jhbuild/ to the final destination.

The problem comes from this part of the code in jhbuild (revision 1eedc423f75c605224b430579e4c303292199507). In file jhbuild/jhbuild/modtypes/__initi__.py:

    if os.path.isdir(src_path):
        if os.path.exists(dest_path):
            if not os.path.isdir(dest_path):
                os.unlink(dest_path)
                os.mkdir(dest_path)
        else:
            os.mkdir(dest_path)
        num_copied += self._process_install_files(installroot, src_path, prefix)
        os.rmdir(src_path)


That will fail if src_path is a symlink to a dir, since os.path.isdir() follows links, but os.rmdir() does not.

So I think we should update the minimum required revision to some point where that issue is fixed, and I suggest ddb8b4e64bede55212c7590e2104daff92b72ce0 for that, since it's properly fixed there.
Comment 1 Mario Sanchez Prada 2013-03-26 10:45:45 PDT
Created attachment 195116 [details]
Patch proposal

Here comes the patch
Comment 2 Dominik Röttsches (drott) 2013-03-27 01:27:07 PDT
Thanks, Mario.
Comment 3 Mario Sanchez Prada 2013-03-27 03:37:39 PDT
Comment on attachment 195116 [details]
Patch proposal

Thanks for the review. Setting cq+, since I'm not able to push it myself, for some weird reason
Comment 4 WebKit Review Bot 2013-03-27 17:00:03 PDT
Comment on attachment 195116 [details]
Patch proposal

Clearing flags on attachment: 195116

Committed r147023: <http://trac.webkit.org/changeset/147023>
Comment 5 WebKit Review Bot 2013-03-27 17:00:08 PDT
All reviewed patches have been landed.  Closing bug.