Bug 113315 - Web Inspector: Timeline. Scroll dividers with the underlying events.
Summary: Web Inspector: Timeline. Scroll dividers with the underlying events.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Ilya Tikhonovsky
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-26 09:16 PDT by Ilya Tikhonovsky
Modified: 2013-03-27 00:45 PDT (History)
9 users (show)

See Also:

Attachments
Patch (5.30 KB, patch)
2013-03-26 09:20 PDT, Ilya Tikhonovsky 		pfeldman: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff
screenshot (79.04 KB, image/png)
2013-03-27 00:45 PDT, Ilya Tikhonovsky 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ilya Tikhonovsky 2013-03-26 09:16:48 PDT 
EOM
Comment 1 Ilya Tikhonovsky 2013-03-26 09:20:46 PDT 
Created attachment 195098 [details]
Patch
Comment 2 Pavel Feldman 2013-03-26 09:27:33 PDT 
Comment on attachment 195098 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=195098&action=review

> Source/WebCore/inspector/front-end/TimelinePanel.js:1357
>      grandMinimumBoundary: function()

Lets call this zeroTime
Comment 3 Andrey Kosyakov 2013-03-26 10:12:29 PDT 
This leads to padding always being present in frame mode -- is this the intent?
Comment 4 Build Bot 2013-03-26 11:23:56 PDT 
Comment on attachment 195098 [details]
Patch

Attachment 195098 [details] did not pass win-ews (win):
Output: http://webkit-commit-queue.appspot.com/results/17172699
Comment 5 Ilya Tikhonovsky 2013-03-27 00:34:00 PDT 
Committed r146969: <http://trac.webkit.org/changeset/146969>
Comment 6 Ilya Tikhonovsky 2013-03-27 00:45:30 PDT 
(In reply to comment #3)
> This leads to padding always being present in frame mode -- is this the intent?

It also useful in that case, see screenshot
Comment 7 Ilya Tikhonovsky 2013-03-27 00:45:56 PDT 
Created attachment 195233 [details]
screenshot