Bug 113303 - [CSS Regions] Add performance tests
Summary: [CSS Regions] Add performance tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andrei Bucur
URL:
Keywords: AdobeTracked
Depends on:
Blocks: 66921
  Show dependency treegraph
 
Reported: 2013-03-26 06:14 PDT by Andrei Bucur
Modified: 2013-03-29 07:12 PDT (History)
4 users (show)

See Also:


Attachments
Patch (10.82 KB, patch)
2013-03-28 06:53 PDT, Andrei Bucur
no flags Details | Formatted Diff | Diff
Patch (11.34 KB, patch)
2013-03-29 06:52 PDT, Andrei Bucur
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andrei Bucur 2013-03-26 06:14:18 PDT
We should have a batch of performance tests to use as a baseline for future patches.
Comment 1 Andrei Bucur 2013-03-28 06:53:47 PDT
Created attachment 195561 [details]
Patch
Comment 2 Andrei Bucur 2013-03-28 07:34:16 PDT
Output example from browser:
Running 20 times
Ignoring warm-up run (830.0080001354218 ms)
818.2810000143945 ms
827.1929998882115 ms
833.5410000290722 ms
830.104999942705 ms
829.228000016883 ms
829.634000081569 ms
831.2219998333603 ms
834.9429999943823 ms
831.4069998450577 ms
830.7860000059009 ms
826.5820001251996 ms
828.1519999727607 ms
827.1830000448972 ms
828.347000060603 ms
828.8559999782592 ms
827.7020000386983 ms
826.8569998908788 ms
828.5410001408309 ms
827.7189999353141 ms
826.684000203386 ms
Description: Testing regions with 1200 regions @{width: 300px, height: 200px, maxHeight: auto} and 400 paragraphs

Time:
values 818.2810000143945, 827.1929998882115, 833.5410000290722, 830.104999942705, 829.228000016883, 829.634000081569, 831.2219998333603, 834.9429999943823, 831.4069998450577, 830.7860000059009, 826.5820001251996, 828.1519999727607, 827.1830000448972, 828.347000060603, 828.8559999782592, 827.7020000386983, 826.8569998908788, 828.5410001408309, 827.7189999353141, 826.684000203386 ms
avg 828.6481500021182 ms
median 828.444000100717 ms
stdev 3.332685625247652 ms
min 818.2810000143945 ms
max 834.9429999943823 ms
Comment 3 Antti Koivisto 2013-03-28 07:35:18 PDT
Please check with rniwa too, he is the perf test expert.
Comment 4 Ryosuke Niwa 2013-03-28 15:55:15 PDT
Comment on attachment 195561 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=195561&action=review

> PerformanceTests/ChangeLog:20
> +        * Layout/regions_1200r_300p_fixed_short.html: Added. A lot of short regions with a long content. Tests the impact of unforced breaks
> +        on the layout speed.
> +        * Layout/regions_1200r_400p_auto_maxheight.html: Added. A lot of regions with auto-height and max-height. Tests the impact of
> +        max-height on the auto-height algorithm.
> +        * Layout/regions_1200r_400p_fixed.html: Added. A lot of regions with a long article. Some paragraphs (50%) have forced breaks after.
> +        Stress test for the regions layout algorithm.
> +        * Layout/regions_400r_400p_auto.html: Added. A few regions with a short article. The regions have auto-height and some
> +        paragraphs (80%) have forced breaks after. Stress test for the auto-height algorithm.
> +        * Layout/resources/regions.css: Added.

Please use CamelCase. Also please skip these tests by default by adding them to PerformanceTests/Skipped.
Comment 5 Andrei Bucur 2013-03-29 06:52:58 PDT
Created attachment 195739 [details]
Patch
Comment 6 WebKit Review Bot 2013-03-29 07:12:42 PDT
Comment on attachment 195739 [details]
Patch

Clearing flags on attachment: 195739

Committed r147214: <http://trac.webkit.org/changeset/147214>
Comment 7 WebKit Review Bot 2013-03-29 07:12:45 PDT
All reviewed patches have been landed.  Closing bug.