Bug 113298 - Move remaining marquee applying code to StyleBuilder
Summary: Move remaining marquee applying code to StyleBuilder
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Emil A Eklund
URL:
Keywords:
Depends on:
Blocks: 89879
  Show dependency tree / graph
 
Reported: 2013-03-26 05:16 PDT by Emil A Eklund
Modified: 2013-04-01 12:47 PDT (History)
7 users (show)

See Also:

Attachments
Patch (11.75 KB, patch)
2013-03-26 05:20 PDT, Emil A Eklund 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Emil A Eklund 2013-03-26 05:16:49 PDT 
Move applying logic for CSSPropertyWebkitMarqueeIncrement, CSSPropertyWebkitMarqueeRepetition and CSSPropertyWebkitMarqueeSpeed from StyleResolver::applyProperty.
Comment 1 Emil A Eklund 2013-03-26 05:20:12 PDT 
Created attachment 195062 [details]
Patch
Comment 2 Allan Sandfeld Jensen 2013-03-28 06:14:13 PDT 
Comment on attachment 195062 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=195062&action=review

r=me, assuming we have layout tests of marquee CSS.

> Source/WebCore/ChangeLog:12
> +        No new tests, no change in functionality.

Do we have tests testing marquee CSS? If not we should add some.
Comment 3 Emil A Eklund 2013-04-01 12:24:11 PDT 
(In reply to comment #2)
> (From update of attachment 195062 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=195062&action=review
> 
> r=me, assuming we have layout tests of marquee CSS.
> 
> > Source/WebCore/ChangeLog:12
> > +        No new tests, no change in functionality.
> 
> Do we have tests testing marquee CSS? If not we should add some.

We have a handful of tests for it, most notably fast/html/marquee-element.html and fast/css/MarqueeLayoutTest.html
Comment 4 WebKit Review Bot 2013-04-01 12:47:39 PDT 
Comment on attachment 195062 [details]
Patch

Clearing flags on attachment: 195062

Committed r147350: <http://trac.webkit.org/changeset/147350>
Comment 5 WebKit Review Bot 2013-04-01 12:47:43 PDT 
All reviewed patches have been landed.  Closing bug.