Bug 113287 - [Qt] Enable release/debug/2/webkit2 options for run-qtwebkit-tests
Summary: [Qt] Enable release/debug/2/webkit2 options for run-qtwebkit-tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Csaba Osztrogonác
URL:
Keywords: Qt, QtTriaged
Depends on:
Blocks: 113191
  Show dependency tree / graph
 
Reported: 2013-03-26 02:50 PDT by Csaba Osztrogonác
Modified: 2013-03-26 04:57 PDT (History)
9 users (show)

See Also:

Attachments
Patch (3.86 KB, patch)
2013-03-26 03:34 PDT, Csaba Osztrogonác 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Csaba Osztrogonác 2013-03-26 02:50:24 PDT 
It is to be able simplify master.cfg (https://bugs.webkit.org/show_bug.cgi?id=113191)
and make run-qtwebkit-tests more user friendly, because you won't have to pass
WebKitBuild/Release/Source/WebKit2/UIProcess/API/qt/tests/ for WK2 API tests
or WebKitBuild/Release/Source/WebKit/qt/tests/ for WK1 API tests.
Comment 1 Csaba Osztrogonác 2013-03-26 03:34:51 PDT 
Created attachment 195049 [details]
Patch
Comment 2 Jocelyn Turcotte 2013-03-26 04:47:00 PDT 
Comment on attachment 195049 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=195049&action=review

> Tools/Scripts/run-qtwebkit-tests:108
> +                    raise IndexError("Only one directory could be provided.")

Nit: could -> should/must

r=me
Comment 3 Csaba Osztrogonác 2013-03-26 04:48:16 PDT 
(In reply to comment #2)
> (From update of attachment 195049 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=195049&action=review
> 
> > Tools/Scripts/run-qtwebkit-tests:108
> > +                    raise IndexError("Only one directory could be provided.")
> 
> Nit: could -> should/must
> 
> r=me

I didn't touch this line, only moved. But will fix before landing.
Comment 4 Csaba Osztrogonác 2013-03-26 04:52:52 PDT 
Committed r146868: <http://trac.webkit.org/changeset/146868>