Bug 113279 - HTTPHeaderMap::copyData() could call uncheckedAppend()
Summary: HTTPHeaderMap::copyData() could call uncheckedAppend()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-26 01:01 PDT by Chris Dumez
Modified: 2013-03-26 10:07 PDT (History)
5 users (show)

See Also:


Attachments
Patch (1.73 KB, patch)
2013-03-26 01:51 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2013-03-26 01:01:36 PDT
HTTPHeaderMap::copyData() calls reserveInitialCapacity() on the Vector but then uses append() instead of uncheckedAppend(). Since the capacity was previously reserved, we can call uncheckedAppend() to bypass capacity checks.
Comment 1 Chris Dumez 2013-03-26 01:51:38 PDT
Created attachment 195031 [details]
Patch
Comment 2 WebKit Review Bot 2013-03-26 10:07:22 PDT
Comment on attachment 195031 [details]
Patch

Clearing flags on attachment: 195031

Committed r146899: <http://trac.webkit.org/changeset/146899>
Comment 3 WebKit Review Bot 2013-03-26 10:07:26 PDT
All reviewed patches have been landed.  Closing bug.