Bug 113266 - Web Inspector: [FlameChart] The bar highlighted is not consistent with cursor
Summary: Web Inspector: [FlameChart] The bar highlighted is not consistent with cursor
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-25 19:43 PDT by pdeng6
Modified: 2013-03-26 01:23 PDT (History)
9 users (show)

See Also:


Attachments
Cursor-Highlight-problem (84.45 KB, image/png)
2013-03-25 19:44 PDT, pdeng6
no flags Details
Patch (1.82 KB, patch)
2013-03-25 20:01 PDT, pdeng6
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description pdeng6 2013-03-25 19:43:18 PDT
In FlameChart, function bar highlighted is not consistent with cursor sometimes, snapshot will be uploaded.
In addition, I think flame chart is really useful. :)

thanks
Pan
Comment 1 pdeng6 2013-03-25 19:44:25 PDT
Created attachment 194984 [details]
Cursor-Highlight-problem
Comment 2 pdeng6 2013-03-25 20:01:10 PDT
Created attachment 194988 [details]
Patch
Comment 3 Ilya Tikhonovsky 2013-03-25 20:50:21 PDT
Comment on attachment 194988 [details]
Patch

lgtm. I found that too but the fix was in the patch that hadn't been uploaded.
Comment 4 Build Bot 2013-03-25 23:45:04 PDT
Comment on attachment 194988 [details]
Patch

Attachment 194988 [details] did not pass win-ews (win):
Output: http://webkit-commit-queue.appspot.com/results/17251557
Comment 5 Ilya Tikhonovsky 2013-03-26 01:22:55 PDT
Comment on attachment 194988 [details]
Patch

Clearing flags on attachment: 194988

Committed r146858: <http://trac.webkit.org/changeset/146858>
Comment 6 Ilya Tikhonovsky 2013-03-26 01:23:00 PDT
All reviewed patches have been landed.  Closing bug.