Bug 113265 - When a primary plugin is restarted, also start similar plugins
Summary: When a primary plugin is restarted, also start similar plugins
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Plug-ins (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dean Jackson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2013-03-25 19:36 PDT by Dean Jackson
Modified: 2013-03-26 17:16 PDT (History)
5 users (show)

See Also:

Attachments
Patch (8.51 KB, patch)
2013-03-25 19:46 PDT, Dean Jackson 		no flags Details | Formatted Diff | Diff
Patch (8.54 KB, patch)
2013-03-25 19:48 PDT, Dean Jackson 		no flags Details | Formatted Diff | Diff
Patch (19.25 KB, patch)
2013-03-26 14:15 PDT, Dean Jackson 		no flags Details | Formatted Diff | Diff
Patch (21.94 KB, patch)
2013-03-26 16:33 PDT, Dean Jackson 		thorton: review+
Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dean Jackson 2013-03-25 19:36:46 PDT 
We have the ability to detect if a page has a primary plugin, and restart such a plugin if it has been snapshotted. In this case, we should also restart similar plugins in the page (from the same origins and with the same types).

<rdar://problem/13486852>
Comment 1 Dean Jackson 2013-03-25 19:46:52 PDT 
Created attachment 194986 [details]
Patch
Comment 2 Dean Jackson 2013-03-25 19:48:55 PDT 
Created attachment 194987 [details]
Patch
Comment 3 Dean Jackson 2013-03-26 14:15:28 PDT 
Created attachment 195159 [details]
Patch
Comment 4 Tim Horton 2013-03-26 14:20:40 PDT 
Comment on attachment 195159 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=195159&action=review

> Source/WebKit2/WebProcess/WebProcess.h:288
> +    String m_primaryPlugInPageOrigin;
> +    String m_primaryPlugInOrigin;
> +    String m_primaryPlugInMimeType;

Why is this per-process?
Comment 5 Dean Jackson 2013-03-26 16:33:00 PDT 
Created attachment 195185 [details]
Patch
Comment 6 Dean Jackson 2013-03-26 16:34:27 PDT 
Comment on attachment 195185 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=195185&action=review

> Source/WebCore/ChangeLog:23
> +        (WebCore):

I will remove this line.
Comment 7 Dean Jackson 2013-03-26 17:16:06 PDT 
Committed r146946: <http://trac.webkit.org/changeset/146946>