Bug 113264 – Rename HTMLInputElement::isIndeterminate to Element::shouldAppearIndeterminate

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Kent Tamura]

HTMLInputElement has indeterminate() and isIndeterminate().  It's super confusing.

[Kent Tamura]

Created attachment 194981 [details]
Patch

[Kentaro Hara]

Comment on attachment 194981 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=194981&action=review

> Source/WebCore/html/HTMLProgressElement.cpp:173
> +    return !isDeterminate();

As far as I see the removed code in SelectorChecker.cpp, it looks like that isDeterminate() is a negation of isIndeterminate(). In this patch, isIndeterminate() is remaned to shouldAppearIndeterminate(). Then, don't you want to rename isDeterminate() to something consistent as well (e.g. shouldAppearDeterminate()) ?

[Kent Tamura]

Comment on attachment 194981 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=194981&action=review

>> Source/WebCore/html/HTMLProgressElement.cpp:173
>> +    return !isDeterminate();
> 
> As far as I see the removed code in SelectorChecker.cpp, it looks like that isDeterminate() is a negation of isIndeterminate(). In this patch, isIndeterminate() is remaned to shouldAppearIndeterminate(). Then, don't you want to rename isDeterminate() to something consistent as well (e.g. shouldAppearDeterminate()) ?

I understand you think it's inconsistent, however I feel it's not inconsistent because their roles are different.  shouldAppearDeterminate is a hook for CSS selector matching, isDeterminate represents "determinate" concept in the standard and it is just for HTMLProgressElement.

[Kentaro Hara]

Comment on attachment 194981 [details]
Patch

Makes sense. Thanks for the clarification.

[WebKit Review Bot]

Comment on attachment 194981 [details]
Patch

Clearing flags on attachment: 194981

Committed r146860: <http://trac.webkit.org/changeset/146860>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.