Bug 113261 - REGRESSION(r146657): NRWT shouldn't report image only failures when pixel tests are disabled
Summary: REGRESSION(r146657): NRWT shouldn't report image only failures when pixel tes...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-25 18:33 PDT by Ryosuke Niwa
Modified: 2013-03-25 20:21 PDT (History)
3 users (show)

See Also:


Attachments
Fixes the bug (2.51 KB, patch)
2013-03-25 19:13 PDT, Ryosuke Niwa
no flags Details | Formatted Diff | Diff
Rebaselined the test (2.90 KB, patch)
2013-03-25 19:16 PDT, Ryosuke Niwa
dpranke: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2013-03-25 18:33:47 PDT
When a test failed flakily, we don't want to treat it as a failure or a flaky test even if the test failed with image only failure in retries.
Comment 1 Ryosuke Niwa 2013-03-25 18:34:19 PDT
This bug was observed on http://build.webkit.org/results/Apple%20MountainLion%20Release%20WK2%20(Tests)/r146827%20(7291)/results.html where a bunch of editing/unsupported-content/ tests were reported as failing even though they only had image only failures.
Comment 2 Ryosuke Niwa 2013-03-25 19:13:15 PDT
Created attachment 194978 [details]
Fixes the bug
Comment 3 Ryosuke Niwa 2013-03-25 19:16:54 PDT
Created attachment 194980 [details]
Rebaselined the test
Comment 4 Ryosuke Niwa 2013-03-25 20:21:27 PDT
Committed r146846: <http://trac.webkit.org/changeset/146846>