Bug 113255 - [CSS Exclusions] The radius of a circle should be computed based on the shorter available dimension
Summary: [CSS Exclusions] The radius of a circle should be computed based on the short...
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zoltan Horvath
: 111609 (view as bug list)
Depends on:
Blocks: 89256
  Show dependency treegraph
Reported: 2013-03-25 17:11 PDT by Zoltan Horvath
Modified: 2013-03-26 15:12 PDT (History)
7 users (show)

See Also:

proposed patch (6.07 KB, patch)
2013-03-25 17:29 PDT, Zoltan Horvath
jchaffraix: review+
jchaffraix: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Zoltan Horvath 2013-03-25 17:11:18 PDT
When we decide what should be the radius of a circle, we should choose the smallest available space. For instance when the width or height is not resolvable for the circle we should not have a radius for it.
Comment 1 Zoltan Horvath 2013-03-25 17:29:56 PDT
Created attachment 194961 [details]
proposed patch
Comment 2 Zoltan Horvath 2013-03-26 10:34:52 PDT
*** Bug 111609 has been marked as a duplicate of this bug. ***
Comment 3 Julien Chaffraix 2013-03-26 14:13:37 PDT
Comment on attachment 194961 [details]
proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=194961&action=review

> LayoutTests/fast/exclusions/shape-inside/shape-inside-on-nested-container-with-unresolved-height.html:6
> +    font: 14px Ahem, sans-serif;

Not really needed as it's a ref test and I would expect the font resolution to give similar results on both tests. It also makes the output unreadable by maintainers.

(and btw using 14px as the font size makes little sense, it's a lot easier to use a round number like 10px or 15px so that it's easier to know where the line layout algorithm breaks).

> LayoutTests/fast/exclusions/shape-inside/shape-inside-on-nested-container-with-unresolved-height.html:9
> +    height: 300px;

This is unneeded and should be removed.

> LayoutTests/fast/exclusions/shape-inside/shape-inside-on-nested-container-with-unresolved-height.html:28
> +<p>Requires Ahem font. Since the nested container's height is not resolvable, we shouldn't apply the circle shape-inside on the content.</p>

No need for Ahem.

> LayoutTests/fast/exclusions/shape-inside/shape-inside-on-nested-container-with-unresolved-height.html:29
> +<p>Bug <a href="http://webkit.org/b/113255 ">113255</a>: The radius of a circle should be computed based on the shorter available dimensions</p>

Please add a description (ie what is expected in the output) before landing.
Comment 4 Zoltan Horvath 2013-03-26 15:12:00 PDT
Landed in http://trac.webkit.org/changeset/146938