RESOLVED FIXED Bug 113250
Flakiness dashboard: simplify logic around which tests to show. 
https://bugs.webkit.org/show_bug.cgi?id=113250
Summary Flakiness dashboard: simplify logic around which tests to show.
Julie Parent
Reported 2013-03-25 16:42:10 PDT
Flakiness dashboard: simplify logic around which tests to show.
Attachments
Patch (3.36 KB, patch)
2013-03-25 16:44 PDT, Julie Parent 		no flags
DetailsFormatted DiffDiff
=Added unit tests. (6.17 KB, patch)
2013-03-26 11:41 PDT, Julie Parent 		no flags
DetailsFormatted DiffDiff
Patch for landing (6.18 KB, patch)
2013-03-26 13:24 PDT, Julie Parent 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Julie Parent
Comment 1 2013-03-25 16:44:23 PDT
Created attachment 194947 [details] Patch
Julie Parent
Comment 2 2013-03-25 16:47:59 PDT
Context: This change solves a circular dependence that would arrise when the flakiness dashboard creates its own history object, since we need to know if in layout test mode to set the defaults, and we need the defaults to create the history obj, but we have to have already parsed the parameters to figure out if we are in layout test mode. This simplifies all of the logic and solves the circular dependence.
Ojan Vafai
Comment 3 2013-03-25 16:53:43 PDT
Comment on attachment 194947 [details] Patch It is possible to write a test for shouldHideTest?
Julie Parent
Comment 4 2013-03-26 11:41:17 PDT
Created attachment 195128 [details] =Added unit tests.
Ojan Vafai
Comment 5 2013-03-26 12:23:58 PDT
Comment on attachment 195128 [details] =Added unit tests. View in context: https://bugs.webkit.org/attachment.cgi?id=195128&action=review > Tools/TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:706 > + // FIXME(jparent): Change to use the flakiness_db's history object s/flakiness_db/flakiness_dashboard
Julie Parent
Comment 6 2013-03-26 13:24:09 PDT
Created attachment 195151 [details] Patch for landing
WebKit Review Bot
Comment 7 2013-03-26 13:42:57 PDT
Comment on attachment 195151 [details] Patch for landing Clearing flags on attachment: 195151 Committed r146926: <http://trac.webkit.org/changeset/146926>
WebKit Review Bot
Comment 8 2013-03-26 13:43:01 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.