Bug 113231 – Cleanup plugin snapshotting autostart decision making

• Status: RESOLVED
• Resolution: FIXED
• Component: Plug-ins

[Dean Jackson]

Make a few changes to the way plugins decide to autostart or snapshot:

- move the hashing code from WebCore into the client layer (all WebCore should ask is given a tuple of plugin origin, page origin and mime type, will this plugin autostart?)
- allow for two ways to decide on autostart in WK2. The first is the hash list based on user interaction, the second is an explicit set of autostarts that come from the host

[Radar WebKit Bug Importer]

<rdar://problem/13497730>

[Dean Jackson]

Created attachment 194922 [details]
Patch

[Dean Jackson]

That is the wrong radar. The real one is <rdar://problem/13475462>

[Tim Horton]

Comment on attachment 194922 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=194922&action=review

> Source/WebCore/html/HTMLPlugInImageElement.cpp:415
> +                String otherMimeType = plugInImageElement->serviceType();

Other?

> Source/WebKit2/WebProcess/Plugins/PluginView.cpp:586
> -        if (m_pluginElement->displayState() < HTMLPlugInElement::Playing)
> +        if (m_pluginElement->displayState() == HTMLPlugInElement::RestartingWithPendingMouseClick)
>              m_pluginElement->dispatchPendingMouseClick();

Whoops.

> Source/WebKit2/WebProcess/Plugins/PluginView.cpp:1653
> +    // FIXME: webkit.org/b/113232 - Extend autostart timeout when this codepath is hit.

I'm not sure how we usually format these, but I'm not sure this is it.

[Dean Jackson]

Comment on attachment 194922 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=194922&action=review

>> Source/WebCore/html/HTMLPlugInImageElement.cpp:415
>> +                String otherMimeType = plugInImageElement->serviceType();
> 
> Other?

Yeah, because we're comparing against the mimeType parameter that was passed in. Following the convention that we use in operator== overloads. I'll rename it to loadedMimeType.

>> Source/WebKit2/WebProcess/Plugins/PluginView.cpp:1653
>> +    // FIXME: webkit.org/b/113232 - Extend autostart timeout when this codepath is hit.
> 
> I'm not sure how we usually format these, but I'm not sure this is it.

OK!

[Dean Jackson]

Committed r146823: <http://trac.webkit.org/changeset/146823>

[Dean Jackson]

Reopening to attach new patch.

[Dean Jackson]

Created attachment 194943 [details]
Patch

[Dean Jackson]

Comment on attachment 194943 [details]
Patch

Sent to wrong bug.