Bug 113228 – Don't use video to trigger compositing for layout tests

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Dana Jansens]

Don't use video to trigger compositing for layout tests

[Dana Jansens]

Created attachment 194895 [details]
Patch

[Dana Jansens]

Created attachment 194896 [details]
Patch

rebase to head and typo in changelog

[Adrienne Walker]

Comment on attachment 194896 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=194896&action=review

R=me.  This looks great to me.  Video has always been the cause of a lot of flaky layout tests.

> LayoutTests/compositing/geometry/limit-layer-bounds-opacity-transition.html:15
> +      width: 1px;

It might be worth making this the size of the old video, in the same way that you resize compositing divs elsewhere to avoid expectation churn.

[Dana Jansens]

Comment on attachment 194896 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=194896&action=review

>> LayoutTests/compositing/geometry/limit-layer-bounds-opacity-transition.html:15
>> +      width: 1px;
> 
> It might be worth making this the size of the old video, in the same way that you resize compositing divs elsewhere to avoid expectation churn.

There was some churn anyway, unless I also added a 4px bottom border. It seemed kinda hokey and people in the future would be like "what?" I felt like. Given it's not just a width/height, do you feel differently? If not, I'm happy to add it.

[Dana Jansens]

s/border/margin/

[Dana Jansens]

Created attachment 194911 [details]
Patch

Missed a rebaseline of platform-specific results

[WebKit Review Bot]

Comment on attachment 194911 [details]
Patch

Clearing flags on attachment: 194911

Committed r146814: <http://trac.webkit.org/changeset/146814>